From d07dd4bbedf158635817fd04fa0759537c2e0bd8 Mon Sep 17 00:00:00 2001 From: Quan Tian Date: Fri, 29 Nov 2019 13:31:57 +0800 Subject: [PATCH] Fix NetworkPolicy PolicyTypes validation The validation had an excess nested loop and also caused wrong error feedback that all policyTypes input will be reported as unsupported if any of them is wrong. --- pkg/apis/networking/validation/validation.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/pkg/apis/networking/validation/validation.go b/pkg/apis/networking/validation/validation.go index 6f62f66fe89..11663045dc1 100644 --- a/pkg/apis/networking/validation/validation.go +++ b/pkg/apis/networking/validation/validation.go @@ -123,10 +123,8 @@ func ValidateNetworkPolicySpec(spec *networking.NetworkPolicySpec, fldPath *fiel } for i, pType := range spec.PolicyTypes { policyPath := fldPath.Child("policyTypes").Index(i) - for _, p := range spec.PolicyTypes { - if !allowed.Has(string(p)) { - allErrs = append(allErrs, field.NotSupported(policyPath, pType, []string{string(networking.PolicyTypeIngress), string(networking.PolicyTypeEgress)})) - } + if !allowed.Has(string(pType)) { + allErrs = append(allErrs, field.NotSupported(policyPath, pType, []string{string(networking.PolicyTypeIngress), string(networking.PolicyTypeEgress)})) } } return allErrs