github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 10:51:29 +00:00
Code Issues Projects Releases Wiki Activity

Wait for waitforattach goroutine before exiting

Browse Source 
This test suite fails in weird ways without waiting for the
goroutine
This commit is contained in:
Hemant Kumar 2019-05-20 16:16:16 -04:00
parent e476a60ccb
commit 0ab6bdfa36
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/volume/csi/csi_attacher_test.go
View File

@ -21,6 +21,7 @@ import (
"io/ioutil" "io/ioutil"
"os" "os"
"path/filepath" "path/filepath"
"sync"
"testing" "testing"
"time" "time"
@ -360,9 +361,12 @@ func TestAttacherWithCSIDriver(t *testing.T) {
t.Log("plugin is not attachable") t.Log("plugin is not attachable")
return return
} }
var wg sync.WaitGroup
wg.Add(1)
go func(volSpec *volume.Spec, expectAttach bool) { go func(volSpec *volume.Spec, expectAttach bool) {
attachID, err := csiAttacher.Attach(volSpec, types.NodeName("node")) attachID, err := csiAttacher.Attach(volSpec, types.NodeName("node"))
defer wg.Done()
if err != nil { if err != nil {
t.Errorf("Attach() failed: %s", err) t.Errorf("Attach() failed: %s", err)
} }
@ -378,6 +382,7 @@ func TestAttacherWithCSIDriver(t *testing.T) {
} }
markVolumeAttached(t, csiAttacher.k8s, fakeWatcher, expectedAttachID, status) markVolumeAttached(t, csiAttacher.k8s, fakeWatcher, expectedAttachID, status)
} }
wg.Wait()
}) })
} }
} }