github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-30 06:54:01 +00:00
Code Issues Projects Releases Wiki Activity

Print root cause failure message in StartTestServerOrDie()

Browse Source 
If the server cannot be started then print the underling root cause as
opposed to the generic 'Failed to create server chain'.
This commit is contained in:
Andrew McDermott 2017-08-22 08:10:54 +01:00
parent 07dea6b447
commit 0acda5efc6
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
cmd/kube-apiserver/app/testing/testserver.go
View File

@ -128,8 +128,14 @@ func StartTestServerOrDie(t *testing.T) (*restclient.Config, TearDownFunc) {
// retry test because the bind might fail due to a race with another process // retry test because the bind might fail due to a race with another process
// binding to the port. We cannot listen to :0 (then the kernel would give us // binding to the port. We cannot listen to :0 (then the kernel would give us
// a port which is free for sure), so we need this workaround. // a port which is free for sure), so we need this workaround.
var err error
for retry := 0; retry < 5 && !t.Failed(); retry++ { for retry := 0; retry < 5 && !t.Failed(); retry++ {
config, td, err := StartTestServer(t) var config *restclient.Config
var td TearDownFunc
config, td, err = StartTestServer(t)
if err == nil { if err == nil {
return config, td return config, td
} }
@ -139,7 +145,7 @@ func StartTestServerOrDie(t *testing.T) (*restclient.Config, TearDownFunc) {
t.Logf("Bind error, retrying...") t.Logf("Bind error, retrying...")
} }
t.Fatalf("Failed to launch server") t.Fatalf("Failed to launch server: %v", err)
return nil, nil return nil, nil
} }