github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 15:25:57 +00:00
Code Issues Projects Releases Wiki Activity

utilnode: fix incorrect documentation about node name vs hostname

Browse Source 
(The behavior is unchanged; the function always took a node name
rather than a hostname. Now it just documents that correctly.)
This commit is contained in:
Dan Winship 2020-10-01 11:20:46 -04:00
parent 75242fce7a
commit 0b43753be7
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/util/node/node.go
View File

@ -108,9 +108,9 @@ func GetNodeHostIP(node *v1.Node) (net.IP, error) {
return nil, fmt.Errorf("host IP unknown; known addresses: %v", addresses) return nil, fmt.Errorf("host IP unknown; known addresses: %v", addresses)
} }
// GetNodeIP returns the ip of node with the provided hostname // GetNodeIP returns an IP (as with GetNodeHostIP) for the node with the provided name.
// If required, wait for the node to be defined. // If required, it will wait for the node to be created.
func GetNodeIP(client clientset.Interface, hostname string) net.IP { func GetNodeIP(client clientset.Interface, name string) net.IP {
var nodeIP net.IP var nodeIP net.IP
backoff := wait.Backoff{ backoff := wait.Backoff{
Steps: 6, Steps: 6,
@ -120,7 +120,7 @@ func GetNodeIP(client clientset.Interface, hostname string) net.IP {
} }
err := wait.ExponentialBackoff(backoff, func() (bool, error) { err := wait.ExponentialBackoff(backoff, func() (bool, error) {
node, err := client.CoreV1().Nodes().Get(context.TODO(), hostname, metav1.GetOptions{}) node, err := client.CoreV1().Nodes().Get(context.TODO(), name, metav1.GetOptions{})
if err != nil { if err != nil {
klog.Errorf("Failed to retrieve node info: %v", err) klog.Errorf("Failed to retrieve node info: %v", err)
return false, nil return false, nil