github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-30 23:15:14 +00:00
Code Issues Projects Releases Wiki Activity

store and return deep copies of pod objects to avoid data races

Browse Source
This commit is contained in:
James DeFelice 2016-01-21 22:52:02 +00:00
parent 1eabef0388
commit 0b50f6c513
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
contrib/mesos/pkg/scheduler/integration/integration_test.go
View File

@ -198,13 +198,23 @@ func (lw *MockPodsListWatch) Pod(name string) *api.Pod {
for _, p := range lw.list.Items { for _, p := range lw.list.Items {
if p.Name == name { if p.Name == name {
return &p clone, err := api.Scheme.DeepCopy(&p)
if err != nil {
panic(err.Error())
}
return clone.(*api.Pod)
} }
} }
return nil return nil
} }
func (lw *MockPodsListWatch) Add(pod *api.Pod, notify bool) { func (lw *MockPodsListWatch) Add(pod *api.Pod, notify bool) {
clone, err := api.Scheme.DeepCopy(pod)
if err != nil {
panic(err.Error())
}
pod = clone.(*api.Pod)
func() { func() {
lw.lock.Lock() lw.lock.Lock()
defer lw.lock.Unlock() defer lw.lock.Unlock()
@ -216,6 +226,12 @@ func (lw *MockPodsListWatch) Add(pod *api.Pod, notify bool) {
} }
} }
func (lw *MockPodsListWatch) Modify(pod *api.Pod, notify bool) { func (lw *MockPodsListWatch) Modify(pod *api.Pod, notify bool) {
clone, err := api.Scheme.DeepCopy(pod)
if err != nil {
panic("failed to clone pod object")
}
pod = clone.(*api.Pod)
found := false found := false
func() { func() {
lw.lock.Lock() lw.lock.Lock()