github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-03 17:30:00 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #94421 from rosti/kubeadm-fix-upgrade-plan

Browse Source 
kubeadm: Fix `upgrade plan` for air-gapped setups
This commit is contained in:
Kubernetes Prow Robot 2020-09-02 18:21:54 -07:00 committed by GitHub
commit 0b92e8b16d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
cmd/kubeadm/app/cmd/upgrade/common.go
View File

@ -185,7 +185,15 @@ func enforceRequirements(flags *applyPlanFlags, args []string, dryRun bool, upgr
// If option was specified in both args and config file, args will overwrite the config file. // If option was specified in both args and config file, args will overwrite the config file.
if len(args) == 1 { if len(args) == 1 {
newK8sVersion = args[0] newK8sVersion = args[0]
cfg.KubernetesVersion = newK8sVersion if upgradeApply {
// The `upgrade apply` version always overwrites the KubernetesVersion in the returned cfg with the target
// version. While this is not the same for `upgrade plan` where the KubernetesVersion should be the old
// one (because the call to getComponentConfigVersionStates requires the currently installed version).
// This also makes the KubernetesVersion value returned for `upgrade plan` consistent as that command
// allows to not specify a target version in which case KubernetesVersion will always hold the currently
// installed one.
cfg.KubernetesVersion = newK8sVersion
}
} }
// If features gates are passed to the command line, use it (otherwise use featureGates from configuration) // If features gates are passed to the command line, use it (otherwise use featureGates from configuration)