github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-08 03:33:56 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #123679 from seans3/remotecommand-extend-deadlines

Browse Source 
Extend deadlines to one minute
This commit is contained in:
Kubernetes Prow Robot 2024-03-04 18:38:32 -08:00 committed by GitHub
commit 0bcf6e3dde
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
staging/src/k8s.io/client-go/tools/remotecommand/websocket.go
View File

@ -38,7 +38,7 @@ import (
// writeDeadline defines the time that a client-side write to the websocket // writeDeadline defines the time that a client-side write to the websocket
// connection must complete before an i/o timeout occurs. // connection must complete before an i/o timeout occurs.
const writeDeadline = 30 * time.Second const writeDeadline = 60 * time.Second
var ( var (
_ Executor = &wsStreamExecutor{} _ Executor = &wsStreamExecutor{}
@ -61,8 +61,8 @@ const (
// "pong" message before a timeout error occurs for websocket reading. // "pong" message before a timeout error occurs for websocket reading.
// This duration must always be greater than the "pingPeriod". By defining // This duration must always be greater than the "pingPeriod". By defining
// this deadline in terms of the ping period, we are essentially saying // this deadline in terms of the ping period, we are essentially saying
// we can drop "X-1" (e.g. 6-1=5) pings before firing the timeout. // we can drop "X" (e.g. 12) pings before firing the timeout.
pingReadDeadline = (pingPeriod * 6) + (1 * time.Second) pingReadDeadline = (pingPeriod * 12) + (1 * time.Second)
) )
// wsStreamExecutor handles transporting standard shell streams over an httpstream connection. // wsStreamExecutor handles transporting standard shell streams over an httpstream connection.