From 0c2827cb504a24173deaeaae538ed6512bed281e Mon Sep 17 00:00:00 2001 From: Francesco Romani Date: Mon, 17 Feb 2020 09:53:34 +0100 Subject: [PATCH] e2e: topomgr: remove single-numa node hack On single-NUMA node systems the numa_node of sriov devices was sometimes reported as "-1" instead of, say, 0. This makes some tests that should succeed[0] fail unexpectedly. The reporting works as expected on real multi-NUMA node systems. This small workaround was added to handle this corner case, but it makes overall the code less readable and a bit too lenient, hence we remove it. +++ [0] on a single NUMA node system some resources are obviously always aligned if the pod can be admitted. It boils down to the node capacity at pod admittal time. Signed-off-by: Francesco Romani --- test/e2e_node/numa_alignment.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/e2e_node/numa_alignment.go b/test/e2e_node/numa_alignment.go index 33edd964e8c..11a55ed6186 100644 --- a/test/e2e_node/numa_alignment.go +++ b/test/e2e_node/numa_alignment.go @@ -44,8 +44,7 @@ func (R *numaPodResources) CheckAlignment() bool { } } for _, devNode := range R.PCIDevsToNUMANode { - // TODO: explain -1 - if devNode != -1 && nodeNum != devNode { + if nodeNum != devNode { return false } }