From 0ccab9804a6d47386c27581b7a37bcaff3d418c4 Mon Sep 17 00:00:00 2001
From: Tim Hockin <thockin@google.com>
Date: Fri, 3 Mar 2023 11:56:25 -0800
Subject: [PATCH] Remove obviously redundant tests

---
 .../controllers/service/controller_test.go    | 32 +++++++------------
 1 file changed, 11 insertions(+), 21 deletions(-)

diff --git a/staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go b/staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
index dc3c931e0c5..465c92b1de9 100644
--- a/staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
+++ b/staging/src/k8s.io/cloud-provider/controllers/service/controller_test.go
@@ -2150,6 +2150,17 @@ func Test_shouldSyncUpdatedNode_individualPredicates(t *testing.T) {
 		shouldSync           bool
 		stableNodeSetEnabled bool
 	}{{
+		name:       "nothing changed",
+		oldNode:    makeNode(),
+		newNode:    makeNode(),
+		shouldSync: false,
+	}, {
+		name:                 "nothing changed",
+		oldNode:              makeNode(),
+		newNode:              makeNode(),
+		shouldSync:           false,
+		stableNodeSetEnabled: true,
+	}, {
 		name:       "taint F->T",
 		oldNode:    makeNode(),
 		newNode:    makeNode(tweakAddTaint(ToBeDeletedTaint)),
@@ -2159,11 +2170,6 @@ func Test_shouldSyncUpdatedNode_individualPredicates(t *testing.T) {
 		oldNode:    makeNode(tweakAddTaint(ToBeDeletedTaint)),
 		newNode:    makeNode(),
 		shouldSync: true,
-	}, {
-		name:       "taint F->F",
-		oldNode:    makeNode(),
-		newNode:    makeNode(),
-		shouldSync: false,
 	}, {
 		name:       "taint T->T",
 		oldNode:    makeNode(tweakAddTaint(ToBeDeletedTaint)),
@@ -2194,11 +2200,6 @@ func Test_shouldSyncUpdatedNode_individualPredicates(t *testing.T) {
 		oldNode:    makeNode(tweakSetLabel(v1.LabelNodeExcludeBalancers, "")),
 		newNode:    makeNode(tweakSetLabel(v1.LabelNodeExcludeBalancers, "")),
 		shouldSync: false,
-	}, {
-		name:       "excluded changed F->F",
-		oldNode:    makeNode(),
-		newNode:    makeNode(),
-		shouldSync: false,
 	}, {
 		name:                 "excluded F->T",
 		oldNode:              makeNode(),
@@ -2217,12 +2218,6 @@ func Test_shouldSyncUpdatedNode_individualPredicates(t *testing.T) {
 		newNode:              makeNode(tweakSetLabel(v1.LabelNodeExcludeBalancers, "")),
 		shouldSync:           false,
 		stableNodeSetEnabled: true,
-	}, {
-		name:                 "excluded changed F->F",
-		oldNode:              makeNode(),
-		newNode:              makeNode(),
-		shouldSync:           false,
-		stableNodeSetEnabled: true,
 	}, {
 		name:       "other label changed F->T",
 		oldNode:    makeNode(),
@@ -2243,11 +2238,6 @@ func Test_shouldSyncUpdatedNode_individualPredicates(t *testing.T) {
 		oldNode:    makeNode(),
 		newNode:    makeNode(tweakSetReady(false)),
 		shouldSync: true,
-	}, {
-		name:       "readiness changed T->T",
-		oldNode:    makeNode(),
-		newNode:    makeNode(),
-		shouldSync: false,
 	}, {
 		name:       "readiness changed F->F",
 		oldNode:    makeNode(tweakSetReady(false)),