github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 22:46:12 +00:00
Code Issues Projects Releases Wiki Activity

Avoid unnecessary reallocations of slice in Cacher

Browse Source
This commit is contained in:
Wojciech Tyczynski 2016-10-19 16:45:38 +02:00
parent cbe65701a2
commit 0ced3f43bf
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/storage/cacher.go
View File

@ -389,6 +389,12 @@ func (c *Cacher) List(ctx context.Context, key string, resourceVersion string, p
return fmt.Errorf("failed to wait for fresh list: %v", err) return fmt.Errorf("failed to wait for fresh list: %v", err)
} }
trace.Step(fmt.Sprintf("Listed %d items from cache", len(objs))) trace.Step(fmt.Sprintf("Listed %d items from cache", len(objs)))
if len(objs) > listVal.Cap() && pred.Label.Empty() && pred.Field.Empty() {
// Resize the slice appropriately, since we already know that none
// of the elements will be filtered out.
listVal.Set(reflect.MakeSlice(reflect.SliceOf(c.objectType.Elem()), 0, len(objs)))
trace.Step("Resized result")
}
for _, obj := range objs { for _, obj := range objs {
object, ok := obj.(runtime.Object) object, ok := obj.(runtime.Object)
if !ok { if !ok {