From 0d2952202e8817bd236d1755988a48e490a44167 Mon Sep 17 00:00:00 2001 From: Paco Xu Date: Fri, 16 Dec 2022 16:29:49 +0800 Subject: [PATCH] kubeadm upgrade: fix dry run of backing up kubelet config file Signed-off-by: Paco Xu --- .../app/cmd/phases/upgrade/node/kubeletconfig.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/cmd/kubeadm/app/cmd/phases/upgrade/node/kubeletconfig.go b/cmd/kubeadm/app/cmd/phases/upgrade/node/kubeletconfig.go index 5326bbff52e..2eb50565203 100644 --- a/cmd/kubeadm/app/cmd/phases/upgrade/node/kubeletconfig.go +++ b/cmd/kubeadm/app/cmd/phases/upgrade/node/kubeletconfig.go @@ -78,9 +78,13 @@ func runKubeletConfigPhase() func(c workflow.RunData) error { } src := filepath.Join(kubeletDir, constants.KubeletConfigurationFileName) dest := filepath.Join(backupDir, constants.KubeletConfigurationFileName) - fmt.Printf("[upgrade] backing up kubelet config file to %s\n", dest) - if err := os.Rename(src, dest); err != nil { - return errors.Wrap(err, "error backing up the kubelet config file") + if !dryRun { + fmt.Printf("[upgrade] Backing up kubelet config file to %s\n", dest) + if err := os.Rename(src, dest); err != nil { + return errors.Wrap(err, "error backing up the kubelet config file") + } + } else { + fmt.Printf("[dryrun] Would back up kubelet config file to %s\n", dest) } // Store the kubelet component configuration. if err = kubeletphase.WriteConfigToDisk(&cfg.ClusterConfiguration, kubeletDir, data.PatchesDir(), data.OutputWriter()); err != nil {