github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-13 13:55:41 +00:00
Code Issues Projects Releases Wiki Activity

examine output format before return, fail the test instead of panic

Browse Source
This commit is contained in:
MrHohn 2016-10-04 10:23:53 -07:00
parent 649f6dbf61
commit 0d500921ea
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/e2e/service.go
View File

@ -2347,7 +2347,10 @@ func execSourceipTest(f *framework.Framework, c *client.Client, ns, nodeName, se
// the stdout return from RunHostCmd seems to come with "\n", so TrimSpace is needed // the stdout return from RunHostCmd seems to come with "\n", so TrimSpace is needed
// desired stdout in this format: client_address=x.x.x.x // desired stdout in this format: client_address=x.x.x.x
outputs := strings.Split(strings.TrimSpace(stdout), "=") outputs := strings.Split(strings.TrimSpace(stdout), "=")
sourceIp := outputs[1] if len(outputs) != 2 {
// fail the test if output format is unexpected
return execPodIp, sourceIp framework.Failf("exec pod returned unexpected stdout format: [%v]\n", stdout)
return execPodIp, ""
}
return execPodIp, outputs[1]
} }