From 21896dac4baf66a65355639049628b30083c0d76 Mon Sep 17 00:00:00 2001 From: Chao Xu Date: Thu, 15 Sep 2016 10:45:43 -0700 Subject: [PATCH 1/2] add the uid in a delete event to the absentOwnerCache --- pkg/controller/garbagecollector/garbagecollector.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/controller/garbagecollector/garbagecollector.go b/pkg/controller/garbagecollector/garbagecollector.go index e35857eb8e9..52ff705a6f3 100644 --- a/pkg/controller/garbagecollector/garbagecollector.go +++ b/pkg/controller/garbagecollector/garbagecollector.go @@ -411,6 +411,7 @@ func (p *Propagator) processEvent() { // the node's owners list. p.removeDependentFromOwners(existingNode, removed) case event.eventType == deleteEvent: + p.gc.absentOwnerCache.Add(accessor.GetUID()) if !found { glog.V(6).Infof("%v doesn't exist in the graph, this shouldn't happen", accessor.GetUID()) return From d122de5371d6b41a17c0e6798755b3a38182a1fb Mon Sep 17 00:00:00 2001 From: Chao Xu Date: Thu, 15 Sep 2016 10:45:43 -0700 Subject: [PATCH 2/2] add the uid in a delete event to the absentOwnerCache --- pkg/controller/garbagecollector/garbagecollector_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/controller/garbagecollector/garbagecollector_test.go b/pkg/controller/garbagecollector/garbagecollector_test.go index 4909eac8c07..be1c900e629 100644 --- a/pkg/controller/garbagecollector/garbagecollector_test.go +++ b/pkg/controller/garbagecollector/garbagecollector_test.go @@ -298,8 +298,9 @@ func TestProcessEvent(t *testing.T) { uidToNode: make(map[types.UID]*node), }, gc: &GarbageCollector{ - dirtyQueue: workqueue.NewTimedWorkQueue(), - clock: clock.RealClock{}, + dirtyQueue: workqueue.NewTimedWorkQueue(), + clock: clock.RealClock{}, + absentOwnerCache: NewUIDCache(2), }, } for i := 0; i < len(scenario.events); i++ {