github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

fix a bug on endpointslices tests comparing the wrong metrics

Browse Source
This commit is contained in:
Antonio Ojea 2022-06-17 12:54:16 +02:00
parent 4720f0725c
commit 0d9689a55d
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/controller/endpointslice/reconciler_test.go
View File

@ -1594,7 +1594,7 @@ func TestReconcileTopology(t *testing.T) {
expectedCrossZoneHints: 1, expectedCrossZoneHints: 1,
expectedMetrics: expectedMetrics{ expectedMetrics: expectedMetrics{
desiredSlices: 1, desiredSlices: 1,
actualSlices: 1, actualSlices: 2,
desiredEndpoints: 9, desiredEndpoints: 9,
addedPerSync: 0, addedPerSync: 0,
removedPerSync: 0, removedPerSync: 0,
@ -1617,7 +1617,7 @@ func TestReconcileTopology(t *testing.T) {
expectedCrossZoneHints: 0, expectedCrossZoneHints: 0,
expectedMetrics: expectedMetrics{ expectedMetrics: expectedMetrics{
desiredSlices: 1, desiredSlices: 1,
actualSlices: 1, actualSlices: 2,
desiredEndpoints: 9, desiredEndpoints: 9,
addedPerSync: 0, addedPerSync: 0,
removedPerSync: 0, removedPerSync: 0,
@ -1650,6 +1650,9 @@ func TestReconcileTopology(t *testing.T) {
cmc.Check(t) cmc.Check(t)
expectMetrics(t, tc.expectedMetrics) expectMetrics(t, tc.expectedMetrics)
fetchedSlices := fetchEndpointSlices(t, client, ns) fetchedSlices := fetchEndpointSlices(t, client, ns)
if len(fetchedSlices) != tc.expectedMetrics.actualSlices {
t.Fatalf("Actual slices %d doesn't match metric %d", len(fetchedSlices), tc.expectedMetrics.actualSlices)
}
if tc.expectedHints == nil { if tc.expectedHints == nil {
for _, slice := range fetchedSlices { for _, slice := range fetchedSlices {
@ -1864,7 +1867,7 @@ func expectMetrics(t *testing.T, em expectedMetrics) {
actualNumSlices, err := testutil.GetGaugeMetricValue(metrics.NumEndpointSlices.WithLabelValues()) actualNumSlices, err := testutil.GetGaugeMetricValue(metrics.NumEndpointSlices.WithLabelValues())
handleErr(t, err, "numEndpointSlices") handleErr(t, err, "numEndpointSlices")
if actualDesiredSlices != float64(em.desiredSlices) { if actualNumSlices != float64(em.actualSlices) {
t.Errorf("Expected numEndpointSlices to be %d, got %v", em.actualSlices, actualNumSlices) t.Errorf("Expected numEndpointSlices to be %d, got %v", em.actualSlices, actualNumSlices)
} }