github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-02 16:29:21 +00:00
Code Issues Projects Releases Wiki Activity

Improving deployment e2e failure error messages

Browse Source
This commit is contained in:
nikhiljindal 2016-02-29 18:28:32 -08:00
parent f3d943e0a4
commit 0dae82f6f1
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/util/deployment/deployment.go
View File

@ -206,15 +206,15 @@ func addHashKeyToRSAndPods(deployment *extensions.Deployment, c clientset.Interf
// 2. Update all pods managed by the rs to have the new hash label, so they will be correctly adopted. // 2. Update all pods managed by the rs to have the new hash label, so they will be correctly adopted.
selector, err := unversioned.LabelSelectorAsSelector(updatedRS.Spec.Selector) selector, err := unversioned.LabelSelectorAsSelector(updatedRS.Spec.Selector)
if err != nil { if err != nil {
return nil, err return nil, fmt.Errorf("error in converting selector to label selector for replica set %s: %s", updatedRS.Name, err)
} }
options := api.ListOptions{LabelSelector: selector} options := api.ListOptions{LabelSelector: selector}
podList, err := getPodList(namespace, options) podList, err := getPodList(namespace, options)
if err != nil { if err != nil {
return nil, err return nil, fmt.Errorf("error in getting pod list for namespace %s and list options %+v: %s", namespace, options, err)
} }
if err = labelPodsWithHash(podList, c, namespace, hash); err != nil { if err = labelPodsWithHash(podList, c, namespace, hash); err != nil {
return nil, err return nil, fmt.Errorf("error in adding template hash label %s to pods %+v: %s", hash, podList, err)
} }
glog.V(4).Infof("Labeled rs %s's pods with hash %s.", rs.Name, hash) glog.V(4).Infof("Labeled rs %s's pods with hash %s.", rs.Name, hash)
@ -251,7 +251,7 @@ func labelPodsWithHash(podList *api.PodList, c clientset.Interface, namespace, h
if _, err := updatePodWithRetries(c.Core().Pods(namespace), &pod, func(updated *api.Pod) { if _, err := updatePodWithRetries(c.Core().Pods(namespace), &pod, func(updated *api.Pod) {
pod.Labels = labelsutil.AddLabel(pod.Labels, extensions.DefaultDeploymentUniqueLabelKey, hash) pod.Labels = labelsutil.AddLabel(pod.Labels, extensions.DefaultDeploymentUniqueLabelKey, hash)
}); err != nil { }); err != nil {
return err return fmt.Errorf("error in adding template hash label %s to pod %+v: %s", hash, pod, err)
} }
glog.V(4).Infof("Labeled pod %s with hash %s.", pod.Name, hash) glog.V(4).Infof("Labeled pod %s with hash %s.", pod.Name, hash)
} }
@ -303,6 +303,9 @@ func updatePodWithRetries(podClient unversionedcore.PodInterface, pod *api.Pod,
} }
return false, nil return false, nil
}) })
if err == wait.ErrWaitTimeout {
return nil, fmt.Errorf("timed out trying to update pod: %+v", oldPod)
}
return pod, err return pod, err
} }