mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-08-22 10:06:15 +00:00
Trace.Step() performs an unnecessary ref
Allocates more objects than necessary.
This commit is contained in:
parent
c0b788bf49
commit
0e05f704f3
@ -32,15 +32,19 @@ type traceStep struct {
|
||||
type Trace struct {
|
||||
name string
|
||||
startTime time.Time
|
||||
steps []*traceStep
|
||||
steps []traceStep
|
||||
}
|
||||
|
||||
func NewTrace(name string) *Trace {
|
||||
return &Trace{name, time.Now(), make([]*traceStep, 0)}
|
||||
return &Trace{name, time.Now(), nil}
|
||||
}
|
||||
|
||||
func (t *Trace) Step(msg string) {
|
||||
t.steps = append(t.steps, &traceStep{time.Now(), msg})
|
||||
if t.steps == nil {
|
||||
// traces almost always have less than 6 steps, do this to avoid more than a single allocation
|
||||
t.steps = make([]traceStep, 0, 6)
|
||||
}
|
||||
t.steps = append(t.steps, traceStep{time.Now(), msg})
|
||||
}
|
||||
|
||||
func (t *Trace) Log() {
|
||||
|
Loading…
Reference in New Issue
Block a user