From 0e7814a64795b8a50cb8c5038ae795c613b9d071 Mon Sep 17 00:00:00 2001 From: Han Kang Date: Wed, 12 Oct 2022 09:25:43 -0700 Subject: [PATCH] fix parsing error on labels Change-Id: I990967b93b10dbfa9a564ca4286ffbd051c69697 --- test/instrumentation/find_stable_metric.go | 3 ++- .../testdata/pkg/kubelet/metrics/metrics.go | 8 +++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/test/instrumentation/find_stable_metric.go b/test/instrumentation/find_stable_metric.go index 03605017946..41d3b23a610 100644 --- a/test/instrumentation/find_stable_metric.go +++ b/test/instrumentation/find_stable_metric.go @@ -29,6 +29,7 @@ var metricsOptionStructuresNames = []string{ "GaugeOpts", "HistogramOpts", "SummaryOpts", + "TimingHistogramOpts", } func findStableMetricDeclaration(tree ast.Node, metricsImportName string) ([]*ast.CallExpr, []error) { @@ -98,7 +99,7 @@ func (f *stableMetricFinder) Visit(node ast.Node) (w ast.Visitor) { func isMetricOps(name string) bool { var found = false for _, optsName := range metricsOptionStructuresNames { - if name != optsName { + if name == optsName { found = true break } diff --git a/test/instrumentation/testdata/pkg/kubelet/metrics/metrics.go b/test/instrumentation/testdata/pkg/kubelet/metrics/metrics.go index da29941fb30..1ebd1acac04 100644 --- a/test/instrumentation/testdata/pkg/kubelet/metrics/metrics.go +++ b/test/instrumentation/testdata/pkg/kubelet/metrics/metrics.go @@ -494,7 +494,13 @@ func Register(collectors ...metrics.StableCollector) { return 0 }, )) - + _ = metrics.Labels{ + "probe_type": "1", + "container": "2", + "pod": "podName", + "namespace": "space", + "pod_uid": "123", + } }) }