github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 22:17:14 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #37729 from zmerlynn/fix-hack-e2e-up-dump

Browse Source 
Automatic merge from submit-queue

hack/e2e.go: Dump cluster logs in case of Up failure

**What this PR does / why we need it**: A failure in `Up` currently results in no attempt to grab cluster logs. This fixes that hole. (Sigh, a ton of holes for this diagnosis path.)
This commit is contained in:
Kubernetes Submit Queue 2016-11-30 21:59:06 -08:00 committed by GitHub
commit 0ed38ac647
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
hack/e2e.go
View File

@ -236,6 +236,11 @@ func run(deploy deployer) error {
} }
// Start the cluster using this version. // Start the cluster using this version.
if err := xmlWrap("Up", deploy.Up); err != nil { if err := xmlWrap("Up", deploy.Up); err != nil {
if *dump != "" {
xmlWrap("DumpClusterLogs", func() error {
return DumpClusterLogs(*dump)
})
}
return fmt.Errorf("starting e2e cluster: %s", err) return fmt.Errorf("starting e2e cluster: %s", err)
} }
if *dump != "" { if *dump != "" {