From 8e1e1e9be206c06877d6fe1e201eb53dfa2af4a6 Mon Sep 17 00:00:00 2001 From: yuanhuaiwang Date: Mon, 6 Jul 2020 20:31:28 +0800 Subject: [PATCH] Remove resync period for disruption controller What type of PR is this? /kind cleanup What this PR does / why we need it: The disruption controller is resyncing all ssets every 30 seconds, this is not necessary, and make the depth of disruption workqueue longer and can cause delays processing actual updates when large amounts of disruptions exist. Special notes for your reviewer: Does this PR introduce a user-facing change? Disruption controllers no longer force a resync every 30 seconds when nothing has changed. --- pkg/controller/disruption/disruption.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/controller/disruption/disruption.go b/pkg/controller/disruption/disruption.go index c0a02c2b50a..056238211d9 100644 --- a/pkg/controller/disruption/disruption.go +++ b/pkg/controller/disruption/disruption.go @@ -140,13 +140,12 @@ func NewDisruptionController( dc.podLister = podInformer.Lister() dc.podListerSynced = podInformer.Informer().HasSynced - pdbInformer.Informer().AddEventHandlerWithResyncPeriod( + pdbInformer.Informer().AddEventHandler( cache.ResourceEventHandlerFuncs{ AddFunc: dc.addDb, UpdateFunc: dc.updateDb, DeleteFunc: dc.removeDb, }, - 30*time.Second, ) dc.pdbLister = pdbInformer.Lister() dc.pdbListerSynced = pdbInformer.Informer().HasSynced