mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-23 03:41:45 +00:00
Update misleading comemnts for HandleCrash
This commit is contained in:
parent
0f32f9ef0e
commit
0f0aa9c8f1
@ -40,11 +40,7 @@ var PanicHandlers = []func(interface{}){logPanic}
|
|||||||
// called in case of panic. HandleCrash actually crashes, after calling the
|
// called in case of panic. HandleCrash actually crashes, after calling the
|
||||||
// handlers and logging the panic message.
|
// handlers and logging the panic message.
|
||||||
//
|
//
|
||||||
// TODO: remove this function. We are switching to a world where it's safe for
|
// E.g., you can provide one or more additional handlers for something like shutting down go routines gracefully.
|
||||||
// apiserver to panic, since it will be restarted by kubelet. At the beginning
|
|
||||||
// of the Kubernetes project, nothing was going to restart apiserver and so
|
|
||||||
// catching panics was important. But it's actually much simpler for monitoring
|
|
||||||
// software if we just exit when an unexpected panic happens.
|
|
||||||
func HandleCrash(additionalHandlers ...func(interface{})) {
|
func HandleCrash(additionalHandlers ...func(interface{})) {
|
||||||
if r := recover(); r != nil {
|
if r := recover(); r != nil {
|
||||||
for _, fn := range PanicHandlers {
|
for _, fn := range PanicHandlers {
|
||||||
|
Loading…
Reference in New Issue
Block a user