github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-08 03:33:56 +00:00
Code Issues Projects Releases Wiki Activity

tests: Adds gcr.io Windows image test case

Browse Source 
Adds the test "should be able to pull image from gcr.io [NodeConformance]",
which will pull the the image "gcr.io/kubernetes-e2e-test-images/windows-nanoserver:v1".
The mentioned image is a manifest list, and it works for both
Windows Server 1803 and Windows Server 2019. The manifest list
will have to be amended when a new Windows Server is released.

The command passed to the Windows Container has been changed to
"ping -t localhost", which will keep the container in the Running state,
which is required and checked by the test.
This commit is contained in:
Claudiu Belu 2019-02-26 09:19:53 -08:00
parent 48def74e64
commit 0f12efa8d3
1 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
test/e2e/common/runtime.go
View File

@ -230,13 +230,18 @@ while true; do sleep 1; done
// Images used for ConformanceContainer are not added into NodeImageWhiteList, because this test is // Images used for ConformanceContainer are not added into NodeImageWhiteList, because this test is
// testing image pulling, these images don't need to be prepulled. The ImagePullPolicy // testing image pulling, these images don't need to be prepulled. The ImagePullPolicy
// is v1.PullAlways, so it won't be blocked by framework image white list check. // is v1.PullAlways, so it won't be blocked by framework image white list check.
imagePullTest := func(image string, hasSecret bool, expectedPhase v1.PodPhase, expectedPullStatus bool) { imagePullTest := func(image string, hasSecret bool, expectedPhase v1.PodPhase, expectedPullStatus bool, windowsImage bool) {
command := []string{"/bin/sh", "-c", "while true; do sleep 1; done"}
if windowsImage {
// -t: Ping the specified host until stopped.
command = []string{"ping", "-t", "localhost"}
}
container := ConformanceContainer{ container := ConformanceContainer{
PodClient: f.PodClient(), PodClient: f.PodClient(),
Container: v1.Container{ Container: v1.Container{
Name: "image-pull-test", Name: "image-pull-test",
Image: image, Image: image,
Command: []string{"/bin/sh", "-c", "while true; do sleep 1; done"}, Command: command,
ImagePullPolicy: v1.PullAlways, ImagePullPolicy: v1.PullAlways,
}, },
RestartPolicy: v1.RestartPolicyNever, RestartPolicy: v1.RestartPolicyNever,
@ -328,39 +333,44 @@ while true; do sleep 1; done
It("should not be able to pull image from invalid registry [NodeConformance]", func() { It("should not be able to pull image from invalid registry [NodeConformance]", func() {
image := "invalid.com/invalid/alpine:3.1" image := "invalid.com/invalid/alpine:3.1"
imagePullTest(image, false, v1.PodPending, true) imagePullTest(image, false, v1.PodPending, true, false)
}) })
It("should not be able to pull non-existing image from gcr.io [NodeConformance]", func() { It("should not be able to pull non-existing image from gcr.io [NodeConformance]", func() {
image := "k8s.gcr.io/invalid-image:invalid-tag" image := "k8s.gcr.io/invalid-image:invalid-tag"
imagePullTest(image, false, v1.PodPending, true) imagePullTest(image, false, v1.PodPending, true, false)
}) })
// TODO(claudiub): Add a Windows equivalent test.
It("should be able to pull image from gcr.io [LinuxOnly] [NodeConformance]", func() { It("should be able to pull image from gcr.io [LinuxOnly] [NodeConformance]", func() {
image := "gcr.io/google-containers/debian-base:0.4.1" image := "gcr.io/google-containers/debian-base:0.4.1"
imagePullTest(image, false, v1.PodRunning, false) imagePullTest(image, false, v1.PodRunning, false, false)
})
It("should be able to pull image from gcr.io [NodeConformance]", func() {
framework.SkipUnlessNodeOSDistroIs("windows")
image := "gcr.io/kubernetes-e2e-test-images/windows-nanoserver:v1"
imagePullTest(image, false, v1.PodRunning, false, true)
}) })
It("should be able to pull image from docker hub [LinuxOnly] [NodeConformance]", func() { It("should be able to pull image from docker hub [LinuxOnly] [NodeConformance]", func() {
image := "alpine:3.7" image := "alpine:3.7"
imagePullTest(image, false, v1.PodRunning, false) imagePullTest(image, false, v1.PodRunning, false, false)
}) })
It("should be able to pull image from docker hub [WindowsOnly] [NodeConformance]", func() { It("should be able to pull image from docker hub [WindowsOnly] [NodeConformance]", func() {
framework.SkipUnlessNodeOSDistroIs("windows") framework.SkipUnlessNodeOSDistroIs("windows")
image := "e2eteam/busybox:1.29" image := "e2eteam/busybox:1.29"
imagePullTest(image, false, v1.PodRunning, false) imagePullTest(image, false, v1.PodRunning, false, true)
}) })
It("should not be able to pull from private registry without secret [NodeConformance]", func() { It("should not be able to pull from private registry without secret [NodeConformance]", func() {
image := "gcr.io/authenticated-image-pulling/alpine:3.7" image := "gcr.io/authenticated-image-pulling/alpine:3.7"
imagePullTest(image, false, v1.PodPending, true) imagePullTest(image, false, v1.PodPending, true, false)
}) })
It("should be able to pull from private registry with secret [LinuxOnly] [NodeConformance]", func() { It("should be able to pull from private registry with secret [LinuxOnly] [NodeConformance]", func() {
image := "gcr.io/authenticated-image-pulling/alpine:3.7" image := "gcr.io/authenticated-image-pulling/alpine:3.7"
imagePullTest(image, true, v1.PodRunning, false) imagePullTest(image, true, v1.PodRunning, false, false)
}) })
}) })
}) })