From 7ed6fa7b2e943d2c11c675594a756477ec173032 Mon Sep 17 00:00:00 2001 From: chymy Date: Mon, 14 Mar 2022 16:35:11 +0800 Subject: [PATCH] Method call 'err.Error()' might lead to a nil pointer dereference for pkg/kubelet/cm/cpumanager/cpu_assignment_test.go Signed-off-by: chymy --- pkg/kubelet/cm/cpumanager/cpu_assignment_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kubelet/cm/cpumanager/cpu_assignment_test.go b/pkg/kubelet/cm/cpumanager/cpu_assignment_test.go index 1f9dd09b66f..6d78385f7d8 100644 --- a/pkg/kubelet/cm/cpumanager/cpu_assignment_test.go +++ b/pkg/kubelet/cm/cpumanager/cpu_assignment_test.go @@ -656,7 +656,7 @@ func TestTakeByTopologyNUMAPacked(t *testing.T) { for _, tc := range testCases { t.Run(tc.description, func(t *testing.T) { result, err := takeByTopologyNUMAPacked(tc.topo, tc.availableCPUs, tc.numCPUs) - if tc.expErr != "" && err.Error() != tc.expErr { + if tc.expErr != "" && err != nil && err.Error() != tc.expErr { t.Errorf("expected error to be [%v] but it was [%v]", tc.expErr, err) } if !result.Equals(tc.expResult) {