From ecda7c60c16f121685ff7d62028188b2c1203cb5 Mon Sep 17 00:00:00 2001
From: Davanum Srinivas <davanum@gmail.com>
Date: Sat, 9 Jul 2016 21:56:05 -0400
Subject: [PATCH] Allow empty value for env in kubectl run

Fixes #28734
---
 pkg/kubectl/run.go      | 4 ++--
 pkg/kubectl/run_test.go | 9 +++++++--
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/pkg/kubectl/run.go b/pkg/kubectl/run.go
index 76bafe203ce..3c10d40bba0 100644
--- a/pkg/kubectl/run.go
+++ b/pkg/kubectl/run.go
@@ -934,7 +934,7 @@ func parseEnvs(envArray []string) ([]api.EnvVar, error) {
 		}
 		name := env[:pos]
 		value := env[pos+1:]
-		if len(name) == 0 || len(value) == 0 {
+		if len(name) == 0 {
 			return nil, fmt.Errorf("invalid env: %v", env)
 		}
 		if len(validation.IsCIdentifier(name)) != 0 {
@@ -955,7 +955,7 @@ func parseV1Envs(envArray []string) ([]v1.EnvVar, error) {
 		}
 		name := env[:pos]
 		value := env[pos+1:]
-		if len(name) == 0 || len(validation.IsCIdentifier(name)) != 0 || len(value) == 0 {
+		if len(name) == 0 || len(validation.IsCIdentifier(name)) != 0 {
 			return nil, fmt.Errorf("invalid env: %v", env)
 		}
 		envVar := v1.EnvVar{Name: name, Value: value}
diff --git a/pkg/kubectl/run_test.go b/pkg/kubectl/run_test.go
index 25829b0b749..79c20edc770 100644
--- a/pkg/kubectl/run_test.go
+++ b/pkg/kubectl/run_test.go
@@ -858,8 +858,13 @@ func TestParseEnv(t *testing.T) {
 			envArray: []string{
 				"WITH_OUT_VALUES=",
 			},
-			expected:  []api.EnvVar{},
-			expectErr: true,
+			expected: []api.EnvVar{
+				{
+					Name:  "WITH_OUT_VALUES",
+					Value: "",
+				},
+			},
+			expectErr: false,
 			test:      "test case 3",
 		},
 		{