From 106c5f0b08ccf78ac07ba96c97fa0e848955a317 Mon Sep 17 00:00:00 2001
From: Jan Chaloupka <jchaloup@redhat.com>
Date: Wed, 30 Mar 2016 15:03:40 +0200
Subject: [PATCH] Introduce unit test for checking resource quantities for
 kubelet's allocatable resources.

Covered values:
- negative quantity value: error expected
- invalid quantity unit: error expected
- valid quantity: error not expected

Running go test with -v, returned error are logged as well for more information:

=== RUN   TestValueOfAllocatableResources
--- PASS: TestValueOfAllocatableResources (0.00s)
	server_test.go:47: negative quantity value: resource quantity for \"memory\" cannot be negative: -150G
	server_test.go:47: invalid quantity unit: unable to parse quantity's suffix
PASS
ok  	k8s.io/kubernetes/cmd/kubelet/app	0.020s
---
 cmd/kubelet/app/server_test.go | 72 ++++++++++++++++++++++++++++++++++
 1 file changed, 72 insertions(+)
 create mode 100644 cmd/kubelet/app/server_test.go

diff --git a/cmd/kubelet/app/server_test.go b/cmd/kubelet/app/server_test.go
new file mode 100644
index 00000000000..fac4e7bf3e3
--- /dev/null
+++ b/cmd/kubelet/app/server_test.go
@@ -0,0 +1,72 @@
+/*
+Copyright 2016 The Kubernetes Authors All rights reserved.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package app
+
+import (
+	"k8s.io/kubernetes/pkg/util/config"
+	"testing"
+)
+
+func TestValueOfAllocatableResources(t *testing.T) {
+	testCases := []struct {
+		kubeReserved   string
+		systemReserved string
+		errorExpected  bool
+		name           string
+	}{
+		{
+			kubeReserved:   "cpu=200m,memory=-150G",
+			systemReserved: "cpu=200m,memory=150G",
+			errorExpected:  true,
+			name:           "negative quantity value",
+		},
+		{
+			kubeReserved:   "cpu=200m,memory=150GG",
+			systemReserved: "cpu=200m,memory=150G",
+			errorExpected:  true,
+			name:           "invalid quantity unit",
+		},
+		{
+			kubeReserved:   "cpu=200m,memory=15G",
+			systemReserved: "cpu=200m,memory=15Ki",
+			errorExpected:  false,
+			name:           "Valid resource quantity",
+		},
+	}
+
+	for _, test := range testCases {
+		kubeReservedCM := make(config.ConfigurationMap)
+		systemReservedCM := make(config.ConfigurationMap)
+
+		kubeReservedCM.Set(test.kubeReserved)
+		systemReservedCM.Set(test.systemReserved)
+
+		_, err := parseReservation(kubeReservedCM, systemReservedCM)
+		if err != nil {
+			t.Logf("%s: error returned: %v", test.name, err)
+		}
+		if test.errorExpected {
+			if err == nil {
+				t.Errorf("%s: error expected", test.name)
+			}
+		} else {
+			if err != nil {
+				t.Errorf("%s: unexpected error: %v", test.name, err)
+			}
+		}
+	}
+}