github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 14:07:14 +00:00
Code Issues Projects Releases Wiki Activity

admission/webhook: fix panic from empty response in mutating webhooks

Browse Source
This commit is contained in:
Dr. Stefan Schimanski 2018-02-12 14:58:57 +01:00
parent 72f8a369d0
commit 10969e1b8d
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/mutating/dispatcher.go
View File

@ -20,6 +20,7 @@ package mutating
import ( import (
"context" "context"
"fmt"
"time" "time"
jsonpatch "github.com/evanphx/json-patch" jsonpatch "github.com/evanphx/json-patch"
@ -88,6 +89,10 @@ func (a *mutatingDispatcher) callAttrMutatingHook(ctx context.Context, h *v1beta
return &webhookerrors.ErrCallingWebhook{WebhookName: h.Name, Reason: err} return &webhookerrors.ErrCallingWebhook{WebhookName: h.Name, Reason: err}
} }
if response.Response == nil {
return &webhookerrors.ErrCallingWebhook{WebhookName: h.Name, Reason: fmt.Errorf("Webhook response was absent")}
}
if !response.Response.Allowed { if !response.Response.Allowed {
return webhookerrors.ToStatusErr(h.Name, response.Response.Result) return webhookerrors.ToStatusErr(h.Name, response.Response.Result)
} }