From 10b39d9dd74aacbe57eefbe927fa9ac3064f93fb Mon Sep 17 00:00:00 2001
From: Shyam Jeedigunta <shyamjvs@google.com>
Date: Wed, 14 Dec 2016 17:30:24 +0100
Subject: [PATCH] Fixed kubemark to work when ETCD_X flags are set

---
 test/kubemark/start-kubemark.sh | 33 +++++++++++++--------------------
 test/kubemark/stop-kubemark.sh  |  4 +---
 2 files changed, 14 insertions(+), 23 deletions(-)

diff --git a/test/kubemark/start-kubemark.sh b/test/kubemark/start-kubemark.sh
index 58aa0be5746..4516ef434b5 100755
--- a/test/kubemark/start-kubemark.sh
+++ b/test/kubemark/start-kubemark.sh
@@ -25,35 +25,28 @@ source "${KUBE_ROOT}/test/kubemark/common.sh"
 function writeEnvironmentFile() {
   cat > "${RESOURCE_DIRECTORY}/kubemark-master-env.sh" <<EOF
 # Generic variables.
-INSTANCE_PREFIX=${INSTANCE_PREFIX}
-SERVICE_CLUSTER_IP_RANGE=${SERVICE_CLUSTER_IP_RANGE}
+INSTANCE_PREFIX="${INSTANCE_PREFIX:-}"
+SERVICE_CLUSTER_IP_RANGE="${SERVICE_CLUSTER_IP_RANGE:-}"
 
 # Etcd related variables.
-ETCD_IMAGE=2.2.1
+ETCD_IMAGE="${ETCD_IMAGE:-}"
+ETCD_VERSION="${ETCD_VERSION:-}"
 
 # Controller-manager related variables.
-CONTROLLER_MANAGER_TEST_ARGS="${CONTROLLER_MANAGER_TEST_ARGS}"
-ALLOCATE_NODE_CIDRS=${ALLOCATE_NODE_CIDRS}
-CLUSTER_IP_RANGE=${CLUSTER_IP_RANGE}
-TERMINATED_POD_GC_THRESHOLD=${TERMINATED_POD_GC_THRESHOLD}
+CONTROLLER_MANAGER_TEST_ARGS="${CONTROLLER_MANAGER_TEST_ARGS:-}"
+ALLOCATE_NODE_CIDRS="${ALLOCATE_NODE_CIDRS:-}"
+CLUSTER_IP_RANGE="${CLUSTER_IP_RANGE:-}"
+TERMINATED_POD_GC_THRESHOLD="${TERMINATED_POD_GC_THRESHOLD:-}"
 
 # Scheduler related variables.
-SCHEDULER_TEST_ARGS="${SCHEDULER_TEST_ARGS}"
+SCHEDULER_TEST_ARGS="${SCHEDULER_TEST_ARGS:-}"
 
 # Apiserver related variables.
-APISERVER_TEST_ARGS="${APISERVER_TEST_ARGS}"
-STORAGE_BACKEND=${STORAGE_BACKEND}
-NUM_NODES=${NUM_NODES}
+APISERVER_TEST_ARGS="${APISERVER_TEST_ARGS:-}"
+STORAGE_BACKEND="${STORAGE_BACKEND:-}"
+NUM_NODES="${NUM_NODES:-}"
+CUSTOM_ADMISSION_PLUGINS="${CUSTOM_ADMISSION_PLUGINS:-NamespaceLifecycle,LimitRanger,ServiceAccount,ResourceQuota}"
 EOF
-if [ -z "${CUSTOM_ADMISSION_PLUGINS:-}" ]; then
-  cat >> "${RESOURCE_DIRECTORY}/kubemark-master-env.sh" <<EOF
-CUSTOM_ADMISSION_PLUGINS=NamespaceLifecycle,LimitRanger,ServiceAccount,ResourceQuota
-EOF
-else
-  cat >> "${RESOURCE_DIRECTORY}/kubemark-master-env.sh" <<EOF
-CUSTOM_ADMISSION_PLUGINS=${CUSTOM_ADMISSION_PLUGINS}
-EOF
-fi
 }
 
 MAKE_DIR="${KUBE_ROOT}/cluster/images/kubemark"
diff --git a/test/kubemark/stop-kubemark.sh b/test/kubemark/stop-kubemark.sh
index 0d894250aaa..0ee2477deff 100755
--- a/test/kubemark/stop-kubemark.sh
+++ b/test/kubemark/stop-kubemark.sh
@@ -57,6 +57,4 @@ rm "${RESOURCE_DIRECTORY}/ca.crt" \
 	"${RESOURCE_DIRECTORY}/kubecfg.crt" \
 	"${RESOURCE_DIRECTORY}/kubecfg.key" \
 	"${RESOURCE_DIRECTORY}/hollow-node.json" \
-	"${RESOURCE_DIRECTORY}/apiserver_flags" \
-	"${RESOURCE_DIRECTORY}/controllers_flags" \
-	"${RESOURCE_DIRECTORY}/scheduler_flags" &> /dev/null || true
+	"${RESOURCE_DIRECTORY}/kubemark-master-env.sh"  &> /dev/null || true