From 10f7c34c1642512d02995cd3b03635e356c003cd Mon Sep 17 00:00:00 2001 From: pranshul gupta Date: Fri, 27 Feb 2026 09:00:07 +0530 Subject: [PATCH] added exceptions for StorageVersion.Spec , StorageVersion.Status , StorageVersionCondition.LastTransitionTime to be a pointer and StorageVersion.Spec and StorageVersion.Status to have omitempty tag --- hack/golangci-hints.yaml | 11 ++++++++++- hack/golangci.yaml | 11 ++++++++++- hack/kube-api-linter/exceptions.yaml | 11 ++++++++++- 3 files changed, 30 insertions(+), 3 deletions(-) diff --git a/hack/golangci-hints.yaml b/hack/golangci-hints.yaml index 22bff4e97be..022417c7887 100644 --- a/hack/golangci-hints.yaml +++ b/hack/golangci-hints.yaml @@ -167,7 +167,16 @@ linters: path: "staging/src/k8s.io/api/(admission|admissionregistration|apps|authentication|authorization|autoscaling|batch|certificates|coordination|core|discovery|events|extensions|flowcontrol|imagepolicy|networking|node|policy|rbac|resource|scheduling|storage|storagemigration)" - text: "optionalfields: field StorageVersionCondition.ObservedGeneration should be a pointer." path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" - + - text: "optionalfields: field StorageVersion.Spec should be a pointer." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" + - text: "optionalfields: field StorageVersion.Status should be a pointer." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" + - text: "optionalfields: field StorageVersionCondition.LastTransitionTime should be a pointer." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" + - text: "optionalfields: field StorageVersion.Spec should have the omitempty tag." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" + - text: "optionalfields: field StorageVersion.Status should have the omitempty tag." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" # Pre-existing issues from the conflictmarkers linter # The Error field in some older API types is marked as both optional and required. # This is incorrect, but cannot be changed without breaking changes. diff --git a/hack/golangci.yaml b/hack/golangci.yaml index 3cf7e8508a0..29166908c59 100644 --- a/hack/golangci.yaml +++ b/hack/golangci.yaml @@ -182,7 +182,16 @@ linters: path: "staging/src/k8s.io/api/(admission|admissionregistration|apps|authentication|authorization|autoscaling|batch|certificates|coordination|core|discovery|events|extensions|flowcontrol|imagepolicy|networking|node|policy|rbac|resource|scheduling|storage|storagemigration)" - text: "optionalfields: field StorageVersionCondition.ObservedGeneration should be a pointer." path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" - + - text: "optionalfields: field StorageVersion.Spec should be a pointer." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" + - text: "optionalfields: field StorageVersion.Status should be a pointer." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" + - text: "optionalfields: field StorageVersionCondition.LastTransitionTime should be a pointer." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" + - text: "optionalfields: field StorageVersion.Spec should have the omitempty tag." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" + - text: "optionalfields: field StorageVersion.Status should have the omitempty tag." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" # Pre-existing issues from the conflictmarkers linter # The Error field in some older API types is marked as both optional and required. # This is incorrect, but cannot be changed without breaking changes. diff --git a/hack/kube-api-linter/exceptions.yaml b/hack/kube-api-linter/exceptions.yaml index fa01aab831b..0bed59d7c63 100644 --- a/hack/kube-api-linter/exceptions.yaml +++ b/hack/kube-api-linter/exceptions.yaml @@ -43,7 +43,16 @@ path: "staging/src/k8s.io/api/(admission|admissionregistration|apps|authentication|authorization|autoscaling|batch|certificates|coordination|core|discovery|events|extensions|flowcontrol|imagepolicy|networking|node|policy|rbac|resource|scheduling|storage|storagemigration)" - text: "optionalfields: field StorageVersionCondition.ObservedGeneration should be a pointer." path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" - +- text: "optionalfields: field StorageVersion.Spec should be a pointer." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" +- text: "optionalfields: field StorageVersion.Status should be a pointer." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" +- text: "optionalfields: field StorageVersionCondition.LastTransitionTime should be a pointer." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" +- text: "optionalfields: field StorageVersion.Spec should have the omitempty tag." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" +- text: "optionalfields: field StorageVersion.Status should have the omitempty tag." + path: "staging/src/k8s.io/api/apiserverinternal/v1alpha1/types.go" # Pre-existing issues from the conflictmarkers linter # The Error field in some older API types is marked as both optional and required. # This is incorrect, but cannot be changed without breaking changes.