github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 06:27:05 +00:00
Code Issues Projects Releases Wiki Activity

unittests: Skip test if not on GCE

Browse Source 
The test in pkg/credentialprovider/gcp/metadata_test.go is meant to
run only on GCE, which means that it will fail in any other case.

We should skip the test if we're not testing in GCE or Windows in GCE.
This commit is contained in:
Claudiu Belu 2022-10-18 15:22:55 +03:00
parent 83415e5c9e
commit 1129f57143
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/credentialprovider/gcp/metadata_test.go
View File

@ -26,6 +26,7 @@ import (
"net/url"
"os"
"reflect"
"runtime"
"strings"
"testing"
@ -47,6 +48,12 @@ func createProductNameFile() (string, error) {
// referenced by gceProductNameFile being removed, which is the opposite of
// the other tests
func TestMetadata(t *testing.T) {
// This test requires onGCEVM to return True. On Linux, this can be faked by creating a
// Product Name File. But on Windows, onGCEVM makes the following syscall instead:
// wmic computersystem get model
if runtime.GOOS == "windows" && !onGCEVM() {
t.Skip("Skipping test on Windows, not on GCE.")
}
var err error
gceProductNameFile, err = createProductNameFile()
if err != nil {