diff --git a/hack/.golint_failures b/hack/.golint_failures index 732279ec3dc..299be097528 100644 --- a/hack/.golint_failures +++ b/hack/.golint_failures @@ -103,7 +103,6 @@ pkg/controller/volume/events pkg/controller/volume/expand pkg/controller/volume/persistentvolume pkg/controller/volume/persistentvolume/config/v1alpha1 -pkg/controller/volume/persistentvolume/options pkg/credentialprovider pkg/features pkg/kubeapiserver diff --git a/pkg/controller/volume/persistentvolume/options/options.go b/pkg/controller/volume/persistentvolume/options/options.go index c2c564cc5fd..d80b80a8041 100644 --- a/pkg/controller/volume/persistentvolume/options/options.go +++ b/pkg/controller/volume/persistentvolume/options/options.go @@ -38,11 +38,14 @@ type VolumeConfigFlags struct { EnableDynamicProvisioning bool } +// PersistentVolumeControllerOptions holds the PersistentVolumeController options. type PersistentVolumeControllerOptions struct { PVClaimBinderSyncPeriod time.Duration VolumeConfigFlags VolumeConfigFlags } +// NewPersistentVolumeControllerOptions creates a new PersistentVolumeControllerOptions with +// default values. func NewPersistentVolumeControllerOptions() PersistentVolumeControllerOptions { return PersistentVolumeControllerOptions{ PVClaimBinderSyncPeriod: 15 * time.Second, @@ -59,6 +62,7 @@ func NewPersistentVolumeControllerOptions() PersistentVolumeControllerOptions { } } +// AddFlags adds flags related to PersistentVolumeControllerOptions to the specified FlagSet. func (o *PersistentVolumeControllerOptions) AddFlags(fs *pflag.FlagSet) { fs.DurationVar(&o.PVClaimBinderSyncPeriod, "pvclaimbinder-sync-period", o.PVClaimBinderSyncPeriod, "The period for syncing persistent volumes and persistent volume claims")