From 11a40406a1f809b2f834298d24750455312de25a Mon Sep 17 00:00:00 2001 From: Stephen Heywood Date: Mon, 29 May 2023 11:46:10 +1200 Subject: [PATCH] Promote Ephemeral containers e2e test to Conformance --- test/conformance/testdata/conformance.yaml | 9 +++++++++ test/e2e/common/node/ephemeral_containers.go | 10 +++++++++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/test/conformance/testdata/conformance.yaml b/test/conformance/testdata/conformance.yaml index b0e07c0af45..de4b92346cc 100755 --- a/test/conformance/testdata/conformance.yaml +++ b/test/conformance/testdata/conformance.yaml @@ -1950,6 +1950,15 @@ visible at runtime in the container. release: v1.9 file: test/e2e/common/node/downwardapi.go +- testname: Ephemeral Container, update ephemeral containers + codename: '[sig-node] Ephemeral Containers [NodeConformance] should update the ephemeral + containers in an existing pod [Conformance]' + description: Adding an ephemeral container to pod.spec MUST result in the container + running. There MUST now be only one ephermal container found. Updating the pod + with another ephemeral container MUST succeed. There MUST now be two ephermal + containers found. + release: v1.28 + file: test/e2e/common/node/ephemeral_containers.go - testname: Ephemeral Container Creation codename: '[sig-node] Ephemeral Containers [NodeConformance] will start an ephemeral container in an existing pod [Conformance]' diff --git a/test/e2e/common/node/ephemeral_containers.go b/test/e2e/common/node/ephemeral_containers.go index d9f29f91f9d..452600cf1d6 100644 --- a/test/e2e/common/node/ephemeral_containers.go +++ b/test/e2e/common/node/ephemeral_containers.go @@ -87,7 +87,15 @@ var _ = SIGDescribe("Ephemeral Containers [NodeConformance]", func() { gomega.Expect(log).To(gomega.ContainSubstring("polo")) }) - ginkgo.It("should update the ephemeral containers in an existing pod", func(ctx context.Context) { + /* + Release: v1.28 + Testname: Ephemeral Container, update ephemeral containers + Description: Adding an ephemeral container to pod.spec MUST result in the container + running. There MUST now be only one ephermal container found. Updating the pod with + another ephemeral container MUST succeed. There MUST now be two ephermal containers + found. + */ + framework.ConformanceIt("should update the ephemeral containers in an existing pod", func(ctx context.Context) { ginkgo.By("creating a target pod") pod := podClient.CreateSync(ctx, &v1.Pod{ ObjectMeta: metav1.ObjectMeta{Name: "ephemeral-containers-target-pod"},