From 93a88f551820a115b7ecfdf722e38b35391c93a1 Mon Sep 17 00:00:00 2001 From: carlory Date: Thu, 13 Feb 2025 11:58:33 +0800 Subject: [PATCH] GetRandomReadySchedulableNode nerver return MetricsGrabbingDisabledError Signed-off-by: carlory --- test/e2e/instrumentation/metrics.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e/instrumentation/metrics.go b/test/e2e/instrumentation/metrics.go index d3b062635ab..5ddb0b6cce5 100644 --- a/test/e2e/instrumentation/metrics.go +++ b/test/e2e/instrumentation/metrics.go @@ -59,12 +59,12 @@ var _ = common.SIGDescribe("Metrics", func() { ginkgo.It("should grab all metrics from kubelet /metrics/resource endpoint", func(ctx context.Context) { ginkgo.By("Connecting to kubelet's /metrics/resource endpoint") node, err := e2enode.GetRandomReadySchedulableNode(ctx, f.ClientSet) + framework.ExpectNoError(err) + response, err := grabber.GrabResourceMetricsFromKubelet(ctx, node.Name) if errors.Is(err, e2emetrics.MetricsGrabbingDisabledError) { e2eskipper.Skipf("%v", err) } framework.ExpectNoError(err) - response, err := grabber.GrabResourceMetricsFromKubelet(ctx, node.Name) - framework.ExpectNoError(err) gomega.Expect(response).NotTo(gomega.BeEmpty()) }) })