diff --git a/hack/.staticcheck_failures b/hack/.staticcheck_failures index fdad197f810..b83e01c54ea 100644 --- a/hack/.staticcheck_failures +++ b/hack/.staticcheck_failures @@ -1,7 +1,6 @@ cluster/images/etcd/migrate pkg/controller/replicaset pkg/kubelet/dockershim -pkg/volume/testing test/e2e/autoscaling test/integration/examples test/integration/framework diff --git a/pkg/volume/testing/testing.go b/pkg/volume/testing/testing.go index 7378a4012c1..ae896129183 100644 --- a/pkg/volume/testing/testing.go +++ b/pkg/volume/testing/testing.go @@ -201,14 +201,16 @@ var _ DeviceMountableVolumePlugin = &FakeVolumePlugin{} var _ NodeExpandableVolumePlugin = &FakeVolumePlugin{} func (plugin *FakeVolumePlugin) getFakeVolume(list *[]*FakeVolume) *FakeVolume { - volumeList := *list - if list != nil && len(volumeList) > 0 { - volume := volumeList[0] - volume.Lock() - defer volume.Unlock() - volume.WaitForAttachHook = plugin.WaitForAttachHook - volume.UnmountDeviceHook = plugin.UnmountDeviceHook - return volume + if list != nil { + volumeList := *list + if len(volumeList) > 0 { + volume := volumeList[0] + volume.Lock() + defer volume.Unlock() + volume.WaitForAttachHook = plugin.WaitForAttachHook + volume.UnmountDeviceHook = plugin.UnmountDeviceHook + return volume + } } volume := &FakeVolume{ WaitForAttachHook: plugin.WaitForAttachHook, @@ -217,7 +219,9 @@ func (plugin *FakeVolumePlugin) getFakeVolume(list *[]*FakeVolume) *FakeVolume { volume.VolumesAttached = make(map[string]sets.String) volume.DeviceMountState = make(map[string]string) volume.VolumeMountState = make(map[string]string) - *list = append(*list, volume) + if list != nil { + *list = append(*list, volume) + } return volume }