From 12904ac9117ed1b5352af4fd6bec123914b2f518 Mon Sep 17 00:00:00 2001 From: Matt Matejczyk Date: Tue, 29 Jan 2019 10:18:06 +0100 Subject: [PATCH] Tune suggested master disk sizes for big clusters. Looks like the get-master-root-disk-size() and get-master-disk-size() functions didn't anticipate clusters bigger than 2K nodes. In https://github.com/kubernetes/kubernetes/issues/72976 we found out that 100GB may be not enough for large clusters (5K nodes) when it comes to master root disk size. Updating both get-master-root-disk-size() and get-master-disk-size() to make them consistent and match cluster sizes with get-master-size() function. --- cluster/gce/config-common.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/cluster/gce/config-common.sh b/cluster/gce/config-common.sh index 5ced3e1be99..a6b18002c60 100644 --- a/cluster/gce/config-common.sh +++ b/cluster/gce/config-common.sh @@ -43,12 +43,12 @@ function get-master-size { # NUM_NODES function get-master-root-disk-size() { local suggested_master_root_disk_size="20GB" - if [[ "${NUM_NODES}" -gt "1000" ]]; then - suggested_master_root_disk_size="50GB" - fi - if [[ "${NUM_NODES}" -gt "2000" ]]; then + if [[ "${NUM_NODES}" -gt "500" ]]; then suggested_master_root_disk_size="100GB" fi + if [[ "${NUM_NODES}" -gt "3000" ]]; then + suggested_master_root_disk_size="500GB" + fi echo "${suggested_master_root_disk_size}" } @@ -56,10 +56,10 @@ function get-master-root-disk-size() { # NUM_NODES function get-master-disk-size() { local suggested_master_disk_size="20GB" - if [[ "${NUM_NODES}" -gt "1000" ]]; then + if [[ "${NUM_NODES}" -gt "500" ]]; then suggested_master_disk_size="100GB" fi - if [[ "${NUM_NODES}" -gt "2000" ]]; then + if [[ "${NUM_NODES}" -gt "3000" ]]; then suggested_master_disk_size="200GB" fi echo "${suggested_master_disk_size}"