From 12c0c08e658adddca3372aa4a8067dfbec8078e6 Mon Sep 17 00:00:00 2001 From: lixd Date: Fri, 25 Aug 2023 09:57:28 +0800 Subject: [PATCH] fix data race in test Signed-off-by: lixd --- pkg/kubelet/container/testing/fake_runtime.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pkg/kubelet/container/testing/fake_runtime.go b/pkg/kubelet/container/testing/fake_runtime.go index bf82205303c..a80951b7cc3 100644 --- a/pkg/kubelet/container/testing/fake_runtime.go +++ b/pkg/kubelet/container/testing/fake_runtime.go @@ -81,6 +81,12 @@ type FakeVersion struct { Version string } +func snapshot(imageList []kubecontainer.Image) []kubecontainer.Image { + result := make([]kubecontainer.Image, len(imageList)) + copy(result, imageList) + return result +} + func (fv *FakeVersion) String() string { return fv.Version } @@ -362,7 +368,7 @@ func (f *FakeRuntime) ListImages(_ context.Context) ([]kubecontainer.Image, erro defer f.Unlock() f.CalledFunctions = append(f.CalledFunctions, "ListImages") - return f.ImageList, f.Err + return snapshot(f.ImageList), f.Err } func (f *FakeRuntime) RemoveImage(_ context.Context, image kubecontainer.ImageSpec) error {