From 316ac13d00bf9dd2ee6e2690d6d1749e4d35550b Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Thu, 18 Nov 2021 07:53:16 +0100 Subject: [PATCH] kubelet: print flags after initializing logging If done too soon, the klog.V() calls are ignored because the log verbosity isn't set. In Kubernetes 1.22, the verbosity was set, but not the logging format. --- cmd/kubelet/app/server.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/kubelet/app/server.go b/cmd/kubelet/app/server.go index 5648659699e..95be9f7a945 100644 --- a/cmd/kubelet/app/server.go +++ b/cmd/kubelet/app/server.go @@ -181,7 +181,6 @@ HTTP server: The kubelet can also listen for HTTP and respond to a simple API // short-circuit on verflag verflag.PrintAndExitIfRequested() - cliflag.PrintFlags(cleanFlagSet) // set feature gates from initial flags-based config if err := utilfeature.DefaultMutableFeatureGate.SetFromMap(kubeletConfig.FeatureGates); err != nil { @@ -266,6 +265,7 @@ HTTP server: The kubelet can also listen for HTTP and respond to a simple API klog.ErrorS(err, "Failed to initialize logging") os.Exit(1) } + cliflag.PrintFlags(cleanFlagSet) // construct a KubeletServer from kubeletFlags and kubeletConfig kubeletServer := &options.KubeletServer{