From 135c6899e9ccb160e167f940411d0eb8caa5866b Mon Sep 17 00:00:00 2001 From: Mike Danese Date: Thu, 23 Jun 2016 22:12:13 -0700 Subject: [PATCH] return nil from NewClientConfig instead of empty struct --- .../go2idl/client-gen/generators/generator_for_clientset.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cmd/libs/go2idl/client-gen/generators/generator_for_clientset.go b/cmd/libs/go2idl/client-gen/generators/generator_for_clientset.go index c50be650d1f..17ce06fb73b 100644 --- a/cmd/libs/go2idl/client-gen/generators/generator_for_clientset.go +++ b/cmd/libs/go2idl/client-gen/generators/generator_for_clientset.go @@ -155,14 +155,15 @@ func NewForConfig(c *$.Config|raw$) (*Clientset, error) { var err error $range .allGroups$ clientset.$.Group$Client, err =$.PackageName$.NewForConfig(&configShallowCopy) if err!=nil { - return &clientset, err + return nil, err } $end$ clientset.DiscoveryClient, err = $.NewDiscoveryClientForConfig|raw$(&configShallowCopy) if err!=nil { glog.Errorf("failed to create the DiscoveryClient: %v", err) + return nil, err } - return &clientset, err + return &clientset, nil } `