From e075309b0dadcccfda4b38d1d58981ae5d428d34 Mon Sep 17 00:00:00 2001 From: Guoliang Wang Date: Wed, 25 Apr 2018 10:44:43 +0800 Subject: [PATCH] -Remove TODO comment of GetNonzeroRequests function --- pkg/scheduler/algorithm/priorities/util/non_zero.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/scheduler/algorithm/priorities/util/non_zero.go b/pkg/scheduler/algorithm/priorities/util/non_zero.go index bfbe86d6639..b671945f338 100644 --- a/pkg/scheduler/algorithm/priorities/util/non_zero.go +++ b/pkg/scheduler/algorithm/priorities/util/non_zero.go @@ -32,9 +32,8 @@ const DefaultMilliCPURequest int64 = 100 // 0.1 core // DefaultMemoryRequest defines default memory request size. const DefaultMemoryRequest int64 = 200 * 1024 * 1024 // 200 MB -// GetNonzeroRequests returns the default resource request if none is found or what is provided on the request -// TODO: Consider setting default as a fixed fraction of machine capacity (take "capacity v1.ResourceList" -// as an additional argument here) rather than using constants +// GetNonzeroRequests returns the default resource request if none is found or +// what is provided on the request. func GetNonzeroRequests(requests *v1.ResourceList) (int64, int64) { var outMilliCPU, outMemory int64 // Override if un-set, but not if explicitly set to zero