From 13fa2b1949166ad3ef2d56219eec0e18cc30b4ac Mon Sep 17 00:00:00 2001 From: JUN YANG <69306452+yangjunmyfm192085@users.noreply.github.com> Date: Sat, 29 May 2021 17:20:19 +0800 Subject: [PATCH] replace all occurrences of "node", nodeName to "node", klog.KRef("", nodeName) --- pkg/controller/nodelifecycle/scheduler/taint_manager.go | 2 +- pkg/controller/podgc/gc_controller.go | 2 +- pkg/controller/util/node/controller_utils.go | 4 ++-- .../framework/plugins/defaultbinder/default_binder.go | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/controller/nodelifecycle/scheduler/taint_manager.go b/pkg/controller/nodelifecycle/scheduler/taint_manager.go index 3087e2a687b..9723dbdcb9e 100644 --- a/pkg/controller/nodelifecycle/scheduler/taint_manager.go +++ b/pkg/controller/nodelifecycle/scheduler/taint_manager.go @@ -350,7 +350,7 @@ func (tc *NoExecuteTaintManager) processPodOnNode( } allTolerated, usedTolerations := v1helper.GetMatchingTolerations(taints, tolerations) if !allTolerated { - klog.V(2).InfoS("Not all taints are tolerated after update for pod on node", "pod", podNamespacedName.String(), "node", nodeName) + klog.V(2).InfoS("Not all taints are tolerated after update for pod on node", "pod", podNamespacedName.String(), "node", klog.KRef("", nodeName)) // We're canceling scheduled work (if any), as we're going to delete the Pod right away. tc.cancelWorkWithEvent(podNamespacedName) tc.taintEvictionQueue.AddWork(ctx, NewWorkArgs(podNamespacedName.Name, podNamespacedName.Namespace), time.Now(), time.Now()) diff --git a/pkg/controller/podgc/gc_controller.go b/pkg/controller/podgc/gc_controller.go index b30b933586d..64407490005 100644 --- a/pkg/controller/podgc/gc_controller.go +++ b/pkg/controller/podgc/gc_controller.go @@ -200,7 +200,7 @@ func (gcc *PodGCController) discoverDeletedNodes(ctx context.Context, existingNo exists, err := gcc.checkIfNodeExists(ctx, nodeName) switch { case err != nil: - klog.ErrorS(err, "Error while getting node", "node", nodeName) + klog.ErrorS(err, "Error while getting node", "node", klog.KRef("", nodeName)) // Node will be added back to the queue in the subsequent loop if still needed case !exists: deletedNodesNames.Insert(nodeName) diff --git a/pkg/controller/util/node/controller_utils.go b/pkg/controller/util/node/controller_utils.go index a6c802439b0..f81b57f0c84 100644 --- a/pkg/controller/util/node/controller_utils.go +++ b/pkg/controller/util/node/controller_utils.go @@ -117,7 +117,7 @@ func SetPodTerminationReason(ctx context.Context, kubeClient clientset.Interface // MarkPodsNotReady updates ready status of given pods running on // given node from master return true if success func MarkPodsNotReady(ctx context.Context, kubeClient clientset.Interface, recorder record.EventRecorder, pods []*v1.Pod, nodeName string) error { - klog.V(2).InfoS("Update ready status of pods on node", "node", nodeName) + klog.V(2).InfoS("Update ready status of pods on node", "node", klog.KRef("", nodeName)) errs := []error{} for i := range pods { @@ -165,7 +165,7 @@ func RecordNodeEvent(recorder record.EventRecorder, nodeName, nodeUID, eventtype UID: types.UID(nodeUID), Namespace: "", } - klog.V(2).InfoS("Recording event message for node", "event", event, "node", nodeName) + klog.V(2).InfoS("Recording event message for node", "event", event, "node", klog.KRef("", nodeName)) recorder.Eventf(ref, eventtype, reason, "Node %s event: %s", nodeName, event) } diff --git a/pkg/scheduler/framework/plugins/defaultbinder/default_binder.go b/pkg/scheduler/framework/plugins/defaultbinder/default_binder.go index 414dd6f8832..e695e320dfa 100644 --- a/pkg/scheduler/framework/plugins/defaultbinder/default_binder.go +++ b/pkg/scheduler/framework/plugins/defaultbinder/default_binder.go @@ -49,7 +49,7 @@ func (b DefaultBinder) Name() string { // Bind binds pods to nodes using the k8s client. func (b DefaultBinder) Bind(ctx context.Context, state *framework.CycleState, p *v1.Pod, nodeName string) *framework.Status { - klog.V(3).InfoS("Attempting to bind pod to node", "pod", klog.KObj(p), "nodeName", nodeName) + klog.V(3).InfoS("Attempting to bind pod to node", "pod", klog.KObj(p), "node", klog.KRef("", nodeName)) binding := &v1.Binding{ ObjectMeta: metav1.ObjectMeta{Namespace: p.Namespace, Name: p.Name, UID: p.UID}, Target: v1.ObjectReference{Kind: "Node", Name: nodeName},