github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 19:01:49 +00:00
Code Issues Projects Releases Wiki Activity

Fix go routine leaks

Browse Source 
Close the channel instead of write to it to avoid hanging goroutine.
This commit is contained in:
Msk 2022-11-30 23:50:59 +08:00
parent 57eb5d631c
commit 1444f089fc
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cluster/images/etcd/migrate/migrate_server.go
View File

@ -66,10 +66,10 @@ func (r *EtcdMigrateServer) Start(version *EtcdVersion) error {
}
interval := time.NewTicker(time.Millisecond * 500)
defer interval.Stop()
done := make(chan bool, 1)
done := make(chan bool)
go func() {
time.Sleep(time.Minute * 2)
done <- true
close(done)
}()
for {
select {
@ -108,7 +108,7 @@ func (r *EtcdMigrateServer) Stop() error {
timedout := make(chan bool)
go func() {
time.Sleep(gracefulWait)
timedout <- true
close(timedout)
}()
go func() {
select {
@ -121,7 +121,7 @@ func (r *EtcdMigrateServer) Stop() error {
}
}()
err = r.cmd.Wait()
stopped <- true
close(stopped)
if exiterr, ok := err.(*exec.ExitError); ok {
klog.Infof("etcd server stopped (signal: %s)", exiterr.Error())
// stopped