Add ExecWithOptions to framework

This allows for tweaking more options for executing commands
in pods.

test/e2e/framework/exec_util.go

@@ -30,42 +30,82 @@ import (
 	. "github.com/onsi/gomega"
 )
 
-// ExecCommandInContainer execute a command in the specified container.
+// ExecOptions passed to ExecWithOptions
-// Pass in stdin, tty if needed in the future.
+type ExecOptions struct {
-func (f *Framework) ExecCommandInContainer(podName, containerName string, cmd ...string) string {
+	Command []string
-	stdout, stderr, err := f.ExecCommandInContainerWithFullOutput(podName, containerName, cmd...)
+
-	Logf("Exec stderr: %q", stderr)
+	Namespace     string
-	Expect(err).NotTo(HaveOccurred(), "fail to execute command")
+	PodName       string
-	return stdout
+	ContainerName string
+
+	Stdin         io.Reader
+	CaptureStdout bool
+	CaptureStderr bool
+	// If false, whitespace in std{err,out} will be removed.
+	PreserveWhitespace bool
 }
 
-// ExecCommandInContainerWithFullOutput executes a command in the specified container and return stdout, stderr and error
+// ExecWithOptions executes a command in the specified container,
-func (f *Framework) ExecCommandInContainerWithFullOutput(podName, containerName string, cmd ...string) (string, string, error) {
+// returning stdout, stderr and error. `options` allowed for
-	Logf("Exec running '%s'", strings.Join(cmd, " "))
+// additional parameters to be passed.
+func (f *Framework) ExecWithOptions(options ExecOptions) (string, string, error) {
+	Logf("ExecWithOptions %+v", options)
+
 	config, err := LoadConfig()
 	Expect(err).NotTo(HaveOccurred(), "failed to load restclient config")
-	var stdout, stderr bytes.Buffer
+
-	var stdin io.Reader
+	const tty = false
-	tty := false
+
 	req := f.ClientSet.Core().RESTClient().Post().
 		Resource("pods").
-		Name(podName).
+		Name(options.PodName).
-		Namespace(f.Namespace.Name).
+		Namespace(options.Namespace).
 		SubResource("exec").
-		Param("container", containerName)
+		Param("container", options.ContainerName)
 	req.VersionedParams(&api.PodExecOptions{
-		Container: containerName,
+		Container: options.ContainerName,
-		Command:   cmd,
+		Command:   options.Command,
-		Stdin:     stdin != nil,
+		Stdin:     options.Stdin != nil,
-		Stdout:    true,
+		Stdout:    options.CaptureStdout,
-		Stderr:    true,
+		Stderr:    options.CaptureStderr,
 		TTY:       tty,
 	}, api.ParameterCodec)
 
-	err = execute("POST", req.URL(), config, stdin, &stdout, &stderr, tty)
+	var stdout, stderr bytes.Buffer
+	err = execute("POST", req.URL(), config, options.Stdin, &stdout, &stderr, tty)
+
+	if options.PreserveWhitespace {
+		return stdout.String(), stderr.String(), err
+	}
 	return strings.TrimSpace(stdout.String()), strings.TrimSpace(stderr.String()), err
 }
 
+// ExecCommandInContainerWithFullOutput executes a command in the
+// specified container and return stdout, stderr and error
+func (f *Framework) ExecCommandInContainerWithFullOutput(podName, containerName string, cmd ...string) (string, string, error) {
+	return f.ExecWithOptions(ExecOptions{
+		Command:       cmd,
+		Namespace:     f.Namespace.Name,
+		PodName:       podName,
+		ContainerName: containerName,
+
+		Stdin:              nil,
+		CaptureStdout:      true,
+		CaptureStderr:      true,
+		PreserveWhitespace: false,
+	})
+}
+
+// ExecCommandInContainer executes a command in the specified container.
+func (f *Framework) ExecCommandInContainer(podName, containerName string, cmd ...string) string {
+	stdout, stderr, err := f.ExecCommandInContainerWithFullOutput(podName, containerName, cmd...)
+	Logf("Exec stderr: %q", stderr)
+	Expect(err).NotTo(HaveOccurred(),
+		"failed to execute command in pod %v, container %v: %v",
+		podName, containerName, err)
+	return stdout
+}
+
 func (f *Framework) ExecShellInContainer(podName, containerName string, cmd string) string {
 	return f.ExecCommandInContainer(podName, containerName, "/bin/sh", "-c", cmd)
 }