github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 13:37:30 +00:00
Code Issues Projects Releases Wiki Activity

Remove noisy log

Browse Source 
The error would be logged every reconciler sync (100 ms).
This commit is contained in:
Jan Safranek 2022-07-29 10:35:36 +02:00
parent 0793ecee3a
commit 1490d51028
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/kubelet/volumemanager/cache/actual_state_of_world.go vendored
View File

@ -824,10 +824,6 @@ func (asw *actualStateOfWorld) PodExistsInVolume(podName volumetypes.UniquePodNa
fullErr := newSELinuxMountMismatchError(volumeName) fullErr := newSELinuxMountMismatchError(volumeName)
if util.IsRWOP(volumeObj.spec) { if util.IsRWOP(volumeObj.spec) {
return false, volumeObj.devicePath, fullErr return false, volumeObj.devicePath, fullErr
} else {
// This is not an error yet, but it will be when support for RWO and RWX volumes is added
// TODO: bump some metric here
klog.V(4).ErrorS(fullErr, "Please report this error in https://github.com/kubernetes/enhancements/issues/1710, together with full Pod yaml file")
} }
} }
} }

2
pkg/kubelet/volumemanager/reconciler/reconciler.go
View File

@ -221,7 +221,7 @@ func (rc *reconciler) mountOrAttachVolumes() {
volumeToMount.DevicePath = devicePath volumeToMount.DevicePath = devicePath
if cache.IsSELinuxMountMismatchError(err) { if cache.IsSELinuxMountMismatchError(err) {
// TODO: check error message + lower frequency, this can be noisy // TODO: check error message + lower frequency, this can be noisy
klog.ErrorS(err, volumeToMount.GenerateErrorDetailed("mount precondition failed", err).Error(), "pod", klog.KObj(volumeToMount.Pod)) klog.ErrorS(err, volumeToMount.GenerateErrorDetailed("mount precondition failed, please report this error in https://github.com/kubernetes/enhancements/issues/1710, together with full Pod yaml file", err).Error(), "pod", klog.KObj(volumeToMount.Pod))
// TODO: report error better, this may be too noisy // TODO: report error better, this may be too noisy
rc.desiredStateOfWorld.AddErrorToPod(volumeToMount.PodName, err.Error()) rc.desiredStateOfWorld.AddErrorToPod(volumeToMount.PodName, err.Error())
} else if cache.IsVolumeNotAttachedError(err) { } else if cache.IsVolumeNotAttachedError(err) {