github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 14:37:00 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #71198 from cofyc/go1.11-GOFLAGS-env

Browse Source 
No need to pass GOFLAGS to $goflags variables with go 1.11
This commit is contained in:
Kubernetes Prow Robot 2019-01-09 23:35:09 -08:00 committed by GitHub
commit 152226c557
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hack/lib/golang.sh
View File

@ -685,9 +685,7 @@ kube::golang::build_binaries() {
local host_platform local host_platform
host_platform=$(kube::golang::host_platform) host_platform=$(kube::golang::host_platform)
# Use eval to preserve embedded quoted strings.
local goflags goldflags goasmflags gogcflags local goflags goldflags goasmflags gogcflags
eval "goflags=(${GOFLAGS:-})"
goldflags="${GOLDFLAGS:-} -s -w $(kube::version::ldflags)" goldflags="${GOLDFLAGS:-} -s -w $(kube::version::ldflags)"
goasmflags="-trimpath=${KUBE_ROOT}" goasmflags="-trimpath=${KUBE_ROOT}"
gogcflags="${GOGCFLAGS:-} -trimpath=${KUBE_ROOT}" gogcflags="${GOGCFLAGS:-} -trimpath=${KUBE_ROOT}"

1
hack/make-rules/test.sh
View File

@ -175,7 +175,6 @@ done
shift $((OPTIND - 1)) shift $((OPTIND - 1))
# Use eval to preserve embedded quoted strings. # Use eval to preserve embedded quoted strings.
eval "goflags=(${GOFLAGS:-})"
eval "testargs=(${KUBE_TEST_ARGS:-})" eval "testargs=(${KUBE_TEST_ARGS:-})"
# Used to filter verbose test output. # Used to filter verbose test output.

3
hack/make-rules/vet.sh
View File

@ -35,9 +35,6 @@ fi
# See https://github.com/golang/go/issues/16086 for details. # See https://github.com/golang/go/issues/16086 for details.
go install ./cmd/... go install ./cmd/...
# Use eval to preserve embedded quoted strings.
eval "goflags=(${GOFLAGS:-})"
# Filter out arguments that start with "-" and move them to goflags. # Filter out arguments that start with "-" and move them to goflags.
targets=() targets=()
for arg; do for arg; do