github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-06 10:43:56 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #125712 from benluddy/remove-cbor-test-skips

Browse Source 
KEP-4222: Remove temporary mechanism for skipping CBOR tests.
This commit is contained in:
Kubernetes Prow Robot 2024-06-26 17:57:04 -07:00 committed by GitHub
commit 152a0ca474
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
staging/src/k8s.io/apimachinery/pkg/runtime/serializer/cbor/internal/modes/appendixa_test.go
View File

@ -69,10 +69,6 @@ func TestAppendixA(t *testing.T) {
reject string // reason the decoder rejects the example reject string // reason the decoder rejects the example
encoded []byte // re-encoded object (only if different from example encoding) encoded []byte // re-encoded object (only if different from example encoding)
reasons []string // reasons for re-encode difference reasons []string // reasons for re-encode difference
// TODO: The cases with nonempty fixme are known to be not working and fixing them
// is an alpha criteria. They're present and skipped for visibility.
fixme string
}{ }{
{ {
example: hex("00"), example: hex("00"),
@ -558,10 +554,6 @@ func TestAppendixA(t *testing.T) {
}, },
} { } {
t.Run(fmt.Sprintf("%x", tc.example), func(t *testing.T) { t.Run(fmt.Sprintf("%x", tc.example), func(t *testing.T) {
if tc.fixme != "" {
t.Skip(tc.fixme) // TODO: Remove once all cases are fixed.
}
var decoded interface{} var decoded interface{}
err := modes.Decode.Unmarshal(tc.example, &decoded) err := modes.Decode.Unmarshal(tc.example, &decoded)
if err != nil { if err != nil {

12
staging/src/k8s.io/apimachinery/pkg/runtime/serializer/cbor/internal/modes/decode_test.go
View File

@ -51,11 +51,6 @@ func TestDecode(t *testing.T) {
into interface{} // prototype for concrete destination type. if nil, decode into empty interface value. into interface{} // prototype for concrete destination type. if nil, decode into empty interface value.
want interface{} want interface{}
assertOnError func(t *testing.T, e error) assertOnError func(t *testing.T, e error)
// TODO: Some failing test cases are included for completeness. The next library
// minor version should allow them all to be fixed. In the meantime, this field
// explains the behavior reason for a particular failure.
fixme string
} }
// Test cases are grouped by the kind of the CBOR data item being decoded, as enumerated in // Test cases are grouped by the kind of the CBOR data item being decoded, as enumerated in
@ -76,13 +71,6 @@ func TestDecode(t *testing.T) {
} }
t.Run(fmt.Sprintf("%s/mode=%s", test.name, modeName), func(t *testing.T) { t.Run(fmt.Sprintf("%s/mode=%s", test.name, modeName), func(t *testing.T) {
if test.fixme != "" {
// TODO: Remove this along with the
// fixme field when the last skipped
// test case is passing.
t.Skip(test.fixme)
}
var dst reflect.Value var dst reflect.Value
if test.into == nil { if test.into == nil {
var i interface{} var i interface{}