From 158c42f4bef13e53484a997740bcb934f7410e1e Mon Sep 17 00:00:00 2001 From: Karl Isenberg Date: Mon, 24 Aug 2015 13:21:17 -0700 Subject: [PATCH] Log Mesos task message on status update - Log error when task state is unknown --- contrib/mesos/pkg/scheduler/scheduler.go | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/contrib/mesos/pkg/scheduler/scheduler.go b/contrib/mesos/pkg/scheduler/scheduler.go index 58e24e144bb..d15e19bf0fd 100644 --- a/contrib/mesos/pkg/scheduler/scheduler.go +++ b/contrib/mesos/pkg/scheduler/scheduler.go @@ -400,14 +400,21 @@ func (k *KubernetesScheduler) StatusUpdate(driver bindings.SchedulerDriver, task taskState := taskStatus.GetState() metrics.StatusUpdates.WithLabelValues(source, reason, taskState.String()).Inc() + message := "none" + if taskStatus.Message != nil { + message = *taskStatus.Message + } + log.Infof( - "task status update %q from %q for task %q on slave %q executor %q for reason %q", + "task status update %q from %q for task %q on slave %q executor %q for reason %q with message %q", taskState.String(), source, taskStatus.TaskId.GetValue(), taskStatus.SlaveId.GetValue(), taskStatus.ExecutorId.GetValue(), - reason) + reason, + message, + ) switch taskState { case mesos.TaskState_TASK_RUNNING, mesos.TaskState_TASK_FINISHED, mesos.TaskState_TASK_STARTING, mesos.TaskState_TASK_STAGING: @@ -443,6 +450,17 @@ func (k *KubernetesScheduler) StatusUpdate(driver bindings.SchedulerDriver, task fallthrough case mesos.TaskState_TASK_LOST, mesos.TaskState_TASK_KILLED: k.reconcileTerminalTask(driver, taskStatus) + default: + log.Errorf( + "unknown task status %q from %q for task %q on slave %q executor %q for reason %q with message %q", + taskState.String(), + source, + taskStatus.TaskId.GetValue(), + taskStatus.SlaveId.GetValue(), + taskStatus.ExecutorId.GetValue(), + reason, + message, + ) } }