From 04f091790ee4f31a13e399b6741f1ccc96be4c23 Mon Sep 17 00:00:00 2001 From: Francesco Romani Date: Fri, 12 Mar 2021 10:24:42 +0100 Subject: [PATCH] e2e: TM: wait for SRIOV devices in pod scope tests The Topology Manager e2e tests wants to run on real multi-NUMA system and want to consume real devices supported by device plugins; SRIOV devices happen to be the most commonly available of such devices. The tests need to wait for resource availability before to actually run the tests, or they will fail with a false negative, also relatively hard to debug. An optimization was added in commit 56106439cf7 to minimize the restarts, speed up the execution and make a nasty, yet not fully understood, flake with SRIOV device plugin much less likely. Unfortunately the pod-scope tests were mistakenly left over. This Patch fixes that. CI lanes did NOT fail (and will not fail) because the CI machines aren't multi NUMA nor expose SRIOV devices, so the relevant portion of the test will just skip, avoiding the issue. However, this resurfaces when running the testsuite on bare metal; this is how we noticed. Signed-off-by: Francesco Romani --- test/e2e_node/topology_manager_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/e2e_node/topology_manager_test.go b/test/e2e_node/topology_manager_test.go index 21a80d7c028..d9c34d92a6b 100644 --- a/test/e2e_node/topology_manager_test.go +++ b/test/e2e_node/topology_manager_test.go @@ -593,6 +593,8 @@ func runTMScopeResourceAlignmentTestSuite(f *framework.Framework, configMap *v1. sd := setupSRIOVConfigOrFail(f, configMap) var ctnAttrs, initCtnAttrs []tmCtnAttribute + waitForSRIOVResources(f, sd) + envInfo := &testEnvInfo{ numaNodes: numaNodes, sriovResourceName: sd.resourceName,