From 15caa134b2860aba409c8ef6b1288e618ced5bc2 Mon Sep 17 00:00:00 2001 From: Francesco Romani Date: Thu, 14 Oct 2021 16:46:16 +0200 Subject: [PATCH] cpumanager: topology: use rich cmp package User the `cmp.Diff` package in the unit tests, moving away from `reflect.DeepEqual`. This gives us a clearer picture of the differences when the tests fail. Signed-off-by: Francesco Romani --- pkg/kubelet/cm/cpumanager/topology/topology_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/kubelet/cm/cpumanager/topology/topology_test.go b/pkg/kubelet/cm/cpumanager/topology/topology_test.go index 36f4ce3d67f..f28bc800c20 100644 --- a/pkg/kubelet/cm/cpumanager/topology/topology_test.go +++ b/pkg/kubelet/cm/cpumanager/topology/topology_test.go @@ -21,6 +21,7 @@ import ( "testing" cadvisorapi "github.com/google/cadvisor/info/v1" + "github.com/google/go-cmp/cmp" "k8s.io/kubernetes/pkg/kubelet/cm/cpuset" ) @@ -202,8 +203,8 @@ func Test_Discover(t *testing.T) { } return } - if !reflect.DeepEqual(got, tt.want) { - t.Errorf("Discover() = %v, want %v", got, tt.want) + if diff := cmp.Diff(got, tt.want); diff != "" { + t.Errorf("Discover() = %v, want %v diff=%s", got, tt.want, diff) } }) }