From 16226c0e18c82f8c4ae12ab0001c7f3e0c017547 Mon Sep 17 00:00:00 2001 From: Robert Roland Date: Thu, 3 Nov 2016 09:12:28 -0700 Subject: [PATCH] Bad conditional in vSphereLogin function With this conditional being == instead of !=, a login would never actually be attempted by this provider, and disk attachments would fail. --- pkg/cloudprovider/providers/vsphere/vsphere.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/cloudprovider/providers/vsphere/vsphere.go b/pkg/cloudprovider/providers/vsphere/vsphere.go index 804931a96bb..b4bfdc42fac 100644 --- a/pkg/cloudprovider/providers/vsphere/vsphere.go +++ b/pkg/cloudprovider/providers/vsphere/vsphere.go @@ -360,7 +360,7 @@ func vSphereLogin(vs *VSphere, ctx context.Context) error { m := session.NewManager(vs.client.Client) // retrieve client's current session u, err := m.UserSession(ctx) - if err == nil && u == nil { + if err == nil && u != nil { // current session is valid return nil }