github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-19 09:52:49 +00:00
Code Issues Projects Releases Wiki Activity

test: demote service ClientIP affinity timeout tests from conformance

Browse Source 
During the September 29th, 2022 SIG-Network meeting we decided to
demote the two affinity timeout conformance tests. This was because:

(a) there is no documented correct behavior for these tests other than
"what kube-proxy does"
(b) even the kube-proxy behavior differs depending on the backend implementation
of iptables, IPVS, or [win]userspace (and winkernel doesn't at all)
(c) iptables uses only srcip matching, while userspace and IPVS use srcip+srcport
(d) IPVS and iptables have different minimum timeouts and we had
to hack up the test itself to make IPVS pass
(e) popular 3rd party network plugins also vary in their implementation

Our plan is to deprecate the current affinity options and re-add specific
options for various behaviors so it's clear exactly what plugins support
and which behavior (if any) we want to require for conformance in the future.

Signed-off-by: Dan Williams <dcbw@redhat.com>
This commit is contained in:
Dan Williams 2022-09-30 10:40:13 -05:00
parent 5556d3336b
commit 1687916844
2 changed files with 2 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
test/conformance/testdata/conformance.yaml vendored
View File

@ -1597,38 +1597,6 @@
named Kubernetes with the Namespace of default.
release: v1.18
file: test/e2e/network/service.go
- testname: Service, NodePort type, session affinity to ClientIP with timeout
codename: '[sig-network] Services should have session affinity timeout work for
NodePort service [LinuxOnly] [Conformance]'
description: 'Create a service of type "NodePort" and provide service port and protocol.
Service''s sessionAffinity is set to "ClientIP" and session affinity timeout is
set. Service creation MUST be successful by assigning a "ClusterIP" to service
and allocating NodePort on all nodes. Create a Replication Controller to ensure
that 3 pods are running and are targeted by the service to serve hostname of the
pod when requests are sent to the service. Create another pod to make requests
to the service on node''s IP and NodePort. Service MUST serve the hostname from
the same pod of the replica for all consecutive requests until timeout. After
timeout, requests MUST be served from different pods of the replica. Service MUST
be reachable over serviceName and the ClusterIP on servicePort. Service MUST also
be reachable over node''s IP on NodePort. [LinuxOnly]: Windows does not support
session affinity.'
release: v1.19
file: test/e2e/network/service.go
- testname: Service, ClusterIP type, session affinity to ClientIP with timeout
codename: '[sig-network] Services should have session affinity timeout work for
service with type clusterIP [LinuxOnly] [Conformance]'
description: 'Create a service of type "ClusterIP". Service''s sessionAffinity is
set to "ClientIP" and session affinity timeout is set. Service creation MUST be
successful by assigning "ClusterIP" to the service. Create a Replication Controller
to ensure that 3 pods are running and are targeted by the service to serve hostname
of the pod when requests are sent to the service. Create another pod to make requests
to the service. Service MUST serve the hostname from the same pod of the replica
for all consecutive requests until timeout expires. After timeout, requests MUST
be served from different pods of the replica. Service MUST be reachable over serviceName
and the ClusterIP on servicePort. [LinuxOnly]: Windows does not support session
affinity.'
release: v1.19
file: test/e2e/network/service.go
- testname: Service, NodePort type, session affinity to ClientIP
codename: '[sig-network] Services should have session affinity work for NodePort
service [LinuxOnly] [Conformance]'

25
test/e2e/network/service.go
View File

@ -2199,17 +2199,7 @@ var _ = common.SIGDescribe("Services", func() {
execAffinityTestForNonLBService(f, cs, svc)
})
/*
Release: v1.19
Testname: Service, ClusterIP type, session affinity to ClientIP with timeout
Description: Create a service of type "ClusterIP". Service's sessionAffinity is set to "ClientIP" and session affinity timeout is set. Service creation MUST be successful by assigning "ClusterIP" to the service.
Create a Replication Controller to ensure that 3 pods are running and are targeted by the service to serve hostname of the pod when requests are sent to the service.
Create another pod to make requests to the service. Service MUST serve the hostname from the same pod of the replica for all consecutive requests until timeout expires.
After timeout, requests MUST be served from different pods of the replica.
Service MUST be reachable over serviceName and the ClusterIP on servicePort.
[LinuxOnly]: Windows does not support session affinity.
*/
framework.ConformanceIt("should have session affinity timeout work for service with type clusterIP [LinuxOnly]", func() {
ginkgo.It("should have session affinity timeout work for service with type clusterIP [LinuxOnly]", func() {
svc := getServeHostnameService("affinity-clusterip-timeout")
svc.Spec.Type = v1.ServiceTypeClusterIP
execAffinityTestForSessionAffinityTimeout(f, cs, svc)
@ -2246,18 +2236,7 @@ var _ = common.SIGDescribe("Services", func() {
execAffinityTestForNonLBService(f, cs, svc)
})
/*
Release: v1.19
Testname: Service, NodePort type, session affinity to ClientIP with timeout
Description: Create a service of type "NodePort" and provide service port and protocol. Service's sessionAffinity is set to "ClientIP" and session affinity timeout is set.
Service creation MUST be successful by assigning a "ClusterIP" to service and allocating NodePort on all nodes.
Create a Replication Controller to ensure that 3 pods are running and are targeted by the service to serve hostname of the pod when requests are sent to the service.
Create another pod to make requests to the service on node's IP and NodePort. Service MUST serve the hostname from the same pod of the replica for all consecutive requests until timeout.
After timeout, requests MUST be served from different pods of the replica.
Service MUST be reachable over serviceName and the ClusterIP on servicePort. Service MUST also be reachable over node's IP on NodePort.
[LinuxOnly]: Windows does not support session affinity.
*/
framework.ConformanceIt("should have session affinity timeout work for NodePort service [LinuxOnly]", func() {
ginkgo.It("should have session affinity timeout work for NodePort service [LinuxOnly]", func() {
svc := getServeHostnameService("affinity-nodeport-timeout")
svc.Spec.Type = v1.ServiceTypeNodePort
execAffinityTestForSessionAffinityTimeout(f, cs, svc)