github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 03:41:45 +00:00
Code Issues Projects Releases Wiki Activity

test/integration: clarify namespace utilities

Browse Source 
For a developer that's not very familiar with the integration flow, it
is very surprising to see that the namespace creation logic does not
create anything and that the namespace deletion logic does not delete
anything, either.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
This commit is contained in:
Steve Kuznetsov 2022-05-09 09:56:11 -07:00
parent b53be1d66e
commit 173c1da99e
No known key found for this signature in database
GPG Key ID: 8821C29EC988D9B4
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/integration/framework/util.go
View File

@ -50,6 +50,8 @@ func CreateTestingNamespace(baseName string, apiserver *httptest.Server, t *test
// TODO: Create a namespace with a given basename.
// Currently we neither create the namespace nor delete all of its contents at the end.
// But as long as tests are not using the same namespaces, this should work fine.
// Note: As the integration tests do not run with admission turned on, it's not actually
// required to persist a Namespace object to create other objects inside of it.
return &v1.Namespace{
ObjectMeta: metav1.ObjectMeta{
// TODO: Once we start creating namespaces, switch to GenerateName.
@ -61,6 +63,8 @@ func CreateTestingNamespace(baseName string, apiserver *httptest.Server, t *test
// DeleteTestingNamespace is currently a no-op function.
func DeleteTestingNamespace(ns *v1.Namespace, apiserver *httptest.Server, t *testing.T) {
// TODO: Remove all resources from a given namespace once we implement CreateTestingNamespace.
// Note: integration tests are not expected to run against persistent fixtures today, so not
// cleaning up data they create has no impact.
}
// GetReadySchedulableNodes addresses the common use case of getting nodes you can do work on.