github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-06 18:54:06 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #44962 from redbaron/fix-misleading-error

Browse Source 
Automatic merge from submit-queue

Remove misleading error from CronJob controller when it can't find parent UID

CronJob controller lists all `Jobs` and then tries to match then against `CronJobs` using parent UID. It reports error if parent UID can't be found which means it reports error  on every job which is not part of CronJob


```release-note
NONE
```
This commit is contained in:
Kubernetes Submit Queue 2017-04-26 12:46:16 -07:00 committed by GitHub
commit 17688c7c4b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/controller/cronjob/utils.go
View File

@ -94,7 +94,7 @@ func groupJobsByParent(js []batchv1.Job) map[types.UID][]batchv1.Job {
for _, job := range js { for _, job := range js {
parentUID, found := getParentUIDFromJob(job) parentUID, found := getParentUIDFromJob(job)
if !found { if !found {
glog.Errorf("Unable to get uid from job %s in namespace %s", job.Name, job.Namespace) glog.V(4).Infof("Unable to get parent uid from job %s in namespace %s", job.Name, job.Namespace)
continue continue
} }
jobsBySj[parentUID] = append(jobsBySj[parentUID], job) jobsBySj[parentUID] = append(jobsBySj[parentUID], job)